Bug 1803756

Summary:	Vm Wizard always shows warning for CD ROM devices
Product:	OpenShift Container Platform	Reporter:	Radim Hrazdil <rhrazdil>
Component:	Console Kubevirt Plugin	Assignee:	Gilad Lekner <glekner>
Status:	CLOSED ERRATA	QA Contact:	Radim Hrazdil <rhrazdil>
Severity:	low	Docs Contact:
Priority:	low
Version:	4.4	CC:	aos-bugs, glekner, gouyang, phbailey, tjelinek, yzamir
Target Milestone:	---
Target Release:	4.5.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1818714 (view as bug list)		Environment:
Last Closed:	2020-08-04 18:00:35 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1818714, 1829542

Description Radim Hrazdil 2020-02-17 11:26:54 UTC

Description of problem:
When a user adds a CD ROM, the default value is always sata, which means that in case of Windows machine, user is always presented with a warning saying that sata is not recommended for CD ROM.



Version-Release number of selected component (if applicable):
4.4

How reproducible:
100%

Steps to Reproduce:
1. Open VM Wizard, select Windows OS, proceed to Virtual Hardware section with CD ROMs
2.
3.

Actual results:
Warning is displayed

Expected results:
Wizard should by default select types of interfaces that are recommended.

Additional info:

Comment 1 Gilad Lekner 2020-02-18 09:52:26 UTC

https://github.com/openshift/console/pull/4349

Comment 2 Tomas Jelinek 2020-02-21 08:54:01 UTC

after some discussions, it turned out that it is correct to have sata - having virtio would lead to an issue where the virtio drivers are on a cd which is connected using virtio so can not be read.

The only actual problem here is that the warning should not be shown in this case. Changing title and priority.

Comment 3 Tomas Jelinek 2020-02-24 07:51:06 UTC

*** Bug 1806374 has been marked as a duplicate of this bug. ***

Comment 5 Yaacov Zamir 2020-05-18 13:46:11 UTC

Notes:

a - The warning saying that sata is not recommended for CD ROM comes from the validation section of the common template used.
b - VM creation Wizard should validate the cdrom bus currectly.

Fix:
a - Make sure the common templates have correct validations:
https://github.com/kubevirt/common-templates/pull/148 - merged

b - Make sure the vVM creation wizard reads the validations currectly.
https://github.com/openshift/console/pull/5334 - submitted

@Gilad should this be post ?

Comment 6 Yaacov Zamir 2020-05-19 14:04:37 UTC

https://github.com/openshift/console/pull/5334 merged

Comment 10 Radim Hrazdil 2020-05-21 12:55:59 UTC

Verified that user is not presented with a warning on Virtual Hardware with Windows OS selected
release-4.5, 531a1d33d7e03f487646c7569d5bce742501cb02

Comment 12 errata-xmlrpc 2020-08-04 18:00:35 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.5 image release advisory), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409