Bug 1804167

Summary: Cannot modify OVS system interface connection profile
Product: Red Hat Enterprise Linux 8 Reporter: Gris Ge <fge>
Component: NetworkManagerAssignee: Thomas Haller <thaller>
Status: CLOSED ERRATA QA Contact: Desktop QE <desktop-qa-list>
Severity: medium Docs Contact:
Priority: medium    
Version: 8.2CC: acardace, atragler, bgalvani, lrintel, mshi, pasik, rkhan, sukulkar, thaller, till, vbenes
Target Milestone: rcFlags: pm-rhel: mirror+
Target Release: 8.2   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: NetworkManager-1.22.8-1.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-04-28 16:54:14 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1738136    
Attachments:
Description Flags
Reproduce script
none
System logs with NM trace enabled none

Description Gris Ge 2020-02-18 11:35:10 UTC
Created attachment 1663737 [details]
Reproduce script

Description of problem:

Try to detach 'eth1' from a OVS bridge. but `nmcli edit` silently ignored
all changes made to `connection.master`, `connection.slave-type` and `ovs-interface.type`.

Version-Release number of selected component (if applicable):
NetworkManager-1.22.7-24704.53b878818c.el8.x86_64

How reproducible:
100%

Steps to Reproduce:
1. ./nm_bug.sh
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Gris Ge 2020-02-18 11:37:41 UTC
Created attachment 1663738 [details]
System logs with NM trace enabled

Comment 2 Beniamino Galvani 2020-02-18 15:10:28 UTC
The issue here is that the ifcfg-rh backend doesn't remove the OVS_PORT=port0 variable from the connection during the update.

This is fixed on master by commit "ifcfg-rh: clear all untouched, known keys before writing ifcfg-rh file":

 https://gitlab.freedesktop.org/NetworkManager/NetworkManager/commit/07262b165d411456680be062df5f74b43d921dca

Comment 3 Thomas Haller 2020-02-18 17:40:29 UTC
fixed on nm-1-22 branch:

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/commit/0c8046574e782ca926d265348d10866f1653aef1


(also, a simpler reproducer in the commit message).


@QA: I think this is a very trivial fix. I don't think it's worth writing a CI test. Manual testing should suffice.

Comment 4 Gris Ge 2020-02-19 06:57:35 UTC
Thanks for the quick fix. It works well.

Comment 7 Till Maas 2020-02-21 08:30:30 UTC
*** Bug 1804561 has been marked as a duplicate of this bug. ***

Comment 8 Vladimir Benes 2020-02-25 14:31:19 UTC
test clear_ovs_settings added

Comment 10 errata-xmlrpc 2020-04-28 16:54:14 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:1847