Bug 1804741
| Summary: | dependency on gnome-keyring is excessive | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Vincent Batts <vbatts> |
| Component: | git | Assignee: | Todd Zullinger <tmz> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 31 | CC: | 7d28c752, amahdal, besser82, c.david86, chrisw, opohorel, pcahyna, pstodulk, sebastian.kisela, tmz |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | git-2.25.1-2.fc31 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-03-16 15:11:50 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Vincent Batts
2020-02-19 14:32:31 UTC
The dependencies come from the libsecret credential helper. The libsecret package added gnome-keyring as a weak dep in 4976bb0 (Recommend gnome-keyring, 2019-09-06). You can avoid that with `dnf install --setopt=install_weak_deps=False git` for now. I'll look at splitting out the libsecret credential now that it's got a bloated dependency set. I pushed a change to rawhide and f32 to split out the libsecret credential helper. I think that's also something which should percolate to f31, but probably deserves some discussion with the other git maintainers and interested parties. When we added the libsecret credential helper I remember checking that doing so had very minimal deps (it only pulled in libsecret itself, as far as I recall). Now that the dependency chain of libsecret has grown quite a bit, it belongs in a subpackage just like we had the for gnome-keyring credential helper. So I view this is a bugfix. I'm sure that some folks have come to rely on its presence and there's no good way to keep everyone happy. If we don't split the package in f31, folks using it must wait for several months to pick up the change when f32 is released. If we push the change to f31 as an update, those who rely on it may be surprised that the functionality disappears and requires an additional package to restore. Anyone feel strongly that this isn't a bugfix which belongs in f31? (It doesn't affect f30, as libsecret doesn't have the gnome-keyring dep there.) For the moment, I did an f31 scratch build with the change here: https://koji.fedoraproject.org/koji/taskinfo?taskID=41790192 (I would have pushed that to my git copr, but we're at the start of an outage while copr is migrated from Fedora's infra cloud to AWS.) FEDORA-2020-f87c04bad1 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-f87c04bad1 git-2.25.1-2.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-f87c04bad1 git-2.25.1-2.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. Uhm, this came unexpected when my git pushes/pulls suddently just did not work anymore. Thankfully I could quickly find this bug/issue here, but to make others aware of that issue, I've announced that in more detail in the forum, too: https://discussion.fedoraproject.org/t/attention-git-credential-libsecret-for-storing-git-passwords-in-the-gnome-keyring-is-now-an-extra-package/18275?u=rugk Sorry for the trouble. Thanks for posting to help others! |