Bug 1804741 - dependency on gnome-keyring is excessive
Summary: dependency on gnome-keyring is excessive
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: git
Version: 31
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Todd Zullinger
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-02-19 14:32 UTC by Vincent Batts
Modified: 2020-03-22 17:02 UTC (History)
10 users (show)

Fixed In Version: git-2.25.1-2.fc31
Clone Of:
Environment:
Last Closed: 2020-03-16 15:11:50 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Vincent Batts 2020-02-19 14:32:31 UTC
Description of problem:
the transitive dependencies of git pull in gtk3, libwayland, cups-lib, etc.

Version-Release number of selected component (if applicable):


How reproducible:
consistent

Steps to Reproduce:
1. from a minimal rootfs, like fedora:31 container image (`podman run -it fedora:31 dnf install -y git`)
2. dnf install -y git
3.

Actual results:
===================================================================================================================================================================================================================
 Package                                                       Architecture                             Version                                                    Repository                                 Size
===================================================================================================================================================================================================================
Installing:
 git                                                           x86_64                                   2.24.1-1.fc31                                              updates                                   135 k
Installing dependencies:
 adwaita-cursor-theme                                          noarch                                   3.34.3-1.fc31                                              updates                                   623 k
 adwaita-icon-theme                                            noarch                                   3.34.3-1.fc31                                              updates                                    11 M
 cups-libs                                                     x86_64                                   1:2.2.12-3.fc31                                            updates                                   276 k
 emacs-filesystem                                              noarch                                   1:26.3-1.fc31                                              updates                                   8.5 k
 fribidi                                                       x86_64                                   1.0.5-5.fc31                                               updates                                    83 k
 gcr                                                           x86_64                                   3.34.0-1.fc31                                              updates                                   481 k
 gcr-base                                                      x86_64                                   3.34.0-1.fc31                                              updates                                   296 k
 git-core                                                      x86_64                                   2.24.1-1.fc31                                              updates                                   4.6 M
 git-core-doc                                                  noarch                                   2.24.1-1.fc31                                              updates                                   2.2 M
 glib-networking                                               x86_64                                   2.62.3-1.fc31                                              updates                                   155 k
 gtk-update-icon-cache                                         x86_64                                   3.24.13-1.fc31                                             updates                                    34 k
 gtk3                                                          x86_64                                   3.24.13-1.fc31                                             updates                                   4.6 M
 libX11                                                        x86_64                                   1.6.9-2.fc31                                               updates                                   659 k
 libX11-common                                                 noarch                                   1.6.9-2.fc31                                               updates                                   153 k
 libedit                                                       x86_64                                   3.1-30.20191211cvs.fc31                                    updates                                   105 k
 libgusb                                                       x86_64                                   0.3.3-1.fc31                                               updates                                    49 k
 libjpeg-turbo                                                 x86_64                                   2.0.2-5.fc31                                               updates                                   168 k
 libsoup                                                       x86_64                                   2.68.3-1.fc31                                              updates                                   383 k
 libtiff                                                       x86_64                                   4.0.10-7.fc31                                              updates                                   179 k
 libxkbcommon                                                  x86_64                                   0.9.1-3.fc31                                               updates                                   120 k
 openssh                                                       x86_64                                   8.1p1-1.fc31                                               updates                                   440 k
 openssh-clients                                               x86_64                                   8.1p1-1.fc31                                               updates                                   601 k
 pango                                                         x86_64                                   1.44.7-1.fc31                                              updates                                   293 k
 perl-Encode                                                   x86_64                                   4:3.02-440.fc31                                            updates                                   1.8 M
 perl-Errno                                                    x86_64                                   1.30-449.fc31                                              updates                                    26 k
 perl-Exporter                                                 noarch                                   5.74-1.fc31                                                updates                                    32 k
 perl-Git                                                      noarch                                   2.24.1-1.fc31                                              updates                                    46 k
 perl-IO                                                       x86_64                                   1.40-449.fc31                                              updates                                    93 k
 perl-Scalar-List-Utils                                        x86_64                                   3:1.53-439.fc31                                            updates                                    66 k
 perl-Storable                                                 x86_64                                   1:3.15-442.fc31                                            updates                                    97 k
 perl-Time-Local                                               noarch                                   2:1.300-1.fc31                                             updates                                    34 k
 perl-interpreter                                              x86_64                                   4:5.30.1-449.fc31                                          updates                                   6.1 M
 perl-libs                                                     x86_64                                   4:5.30.1-449.fc31                                          updates                                   1.7 M
 perl-macros                                                   x86_64                                   4:5.30.1-449.fc31                                          updates                                    21 k
 shared-mime-info                                              x86_64                                   1.15-1.fc31                                                updates                                   303 k
 xkeyboard-config                                              noarch                                   2.28-1.fc31                                                updates                                   753 k
 adobe-source-code-pro-fonts                                   noarch                                   2.030.1.050-7.fc31                                         fedora                                    845 k
 at-spi2-atk                                                   x86_64                                   2.34.1-1.fc31                                              fedora                                     89 k
 at-spi2-core                                                  x86_64                                   2.34.0-1.fc31                                              fedora                                    175 k
 atk                                                           x86_64                                   2.34.1-1.fc31                                              fedora                                    269 k
 avahi-libs                                                    x86_64                                   0.7-20.fc31                                                fedora                                     63 k
 cairo                                                         x86_64                                   1.16.0-6.fc31                                              fedora                                    707 k
 cairo-gobject                                                 x86_64                                   1.16.0-6.fc31                                              fedora                                     20 k
 colord-libs                                                   x86_64                                   1.4.4-2.fc31                                               fedora                                    236 k
 dbus-libs                                                     x86_64                                   1:1.12.16-3.fc31                                           fedora                                    161 k
 fipscheck                                                     x86_64                                   1.5.0-7.fc31                                               fedora                                     26 k
 fipscheck-lib                                                 x86_64                                   1.5.0-7.fc31                                               fedora                                     14 k
 fontconfig                                                    x86_64                                   2.13.92-3.fc31                                             fedora                                    263 k
 fontpackages-filesystem                                       noarch                                   1.44-25.fc31                                               fedora                                    8.1 k
 freetype                                                      x86_64                                   2.10.0-3.fc31                                              fedora                                    384 k
 gdk-pixbuf2                                                   x86_64                                   2.40.0-1.fc31                                              fedora                                    465 k
 gdk-pixbuf2-modules                                           x86_64                                   2.40.0-1.fc31                                              fedora                                     99 k
 graphite2                                                     x86_64                                   1.3.13-1.fc31                                              fedora                                    104 k
 groff-base                                                    x86_64                                   1.22.3-20.fc31                                             fedora                                    1.0 M
 gsettings-desktop-schemas                                     x86_64                                   3.34.0-1.fc31                                              fedora                                    644 k
 harfbuzz                                                      x86_64                                   2.6.1-2.fc31                                               fedora                                    628 k
 hicolor-icon-theme                                            noarch                                   0.17-7.fc31                                                fedora                                     45 k
 jasper-libs                                                   x86_64                                   2.0.14-9.fc31                                              fedora                                    165 k
 jbigkit-libs                                                  x86_64                                   2.1-17.fc31                                                fedora                                     53 k
 json-glib                                                     x86_64                                   1.4.4-3.fc31                                               fedora                                    145 k
 lcms2                                                         x86_64                                   2.9-6.fc31                                                 fedora                                    166 k
 less                                                          x86_64                                   551-2.fc31                                                 fedora                                    154 k
 libXau                                                        x86_64                                   1.0.9-2.fc31                                               fedora                                     31 k
 libXcomposite                                                 x86_64                                   0.4.4-17.fc31                                              fedora                                     23 k
 libXcursor                                                    x86_64                                   1.1.15-6.fc31                                              fedora                                     30 k
 libXdamage                                                    x86_64                                   1.1.4-17.fc31                                              fedora                                     21 k
 libXext                                                       x86_64                                   1.3.4-2.fc31                                               fedora                                     39 k
 libXfixes                                                     x86_64                                   5.0.3-10.fc31                                              fedora                                     19 k
 libXft                                                        x86_64                                   2.3.3-2.fc31                                               fedora                                     64 k
 libXi                                                         x86_64                                   1.7.10-2.fc31                                              fedora                                     39 k
 libXinerama                                                   x86_64                                   1.1.4-4.fc31                                               fedora                                     14 k
 libXrandr                                                     x86_64                                   1.5.2-2.fc31                                               fedora                                     27 k
 libXrender                                                    x86_64                                   0.9.10-10.fc31                                             fedora                                     27 k
 libXtst                                                       x86_64                                   1.2.3-10.fc31                                              fedora                                     21 k
 libdatrie                                                     x86_64                                   0.2.9-10.fc31                                              fedora                                     32 k
 libepoxy                                                      x86_64                                   1.5.3-4.fc31                                               fedora                                    248 k
 libmodman                                                     x86_64                                   2.0.1-20.fc31                                              fedora                                     34 k
 libpng                                                        x86_64                                   2:1.6.37-2.fc31                                            fedora                                    114 k
 libproxy                                                      x86_64                                   0.4.15-14.fc31                                             fedora                                     69 k
 libsecret                                                     x86_64                                   0.19.1-1.fc31                                              fedora                                    171 k
 libthai                                                       x86_64                                   0.1.28-3.fc31                                              fedora                                    213 k
 libwayland-client                                             x86_64                                   1.17.0-2.fc31                                              fedora                                     35 k
 libwayland-cursor                                             x86_64                                   1.17.0-2.fc31                                              fedora                                     20 k
 libwayland-egl                                                x86_64                                   1.17.0-2.fc31                                              fedora                                     13 k
 libxcb                                                        x86_64                                   1.13.1-3.fc31                                              fedora                                    231 k
 perl-Carp                                                     noarch                                   1.50-439.fc31                                              fedora                                     29 k
 perl-Data-Dumper                                              x86_64                                   2.174-440.fc31                                             fedora                                     57 k
 perl-Digest                                                   noarch                                   1.17-439.fc31                                              fedora                                     24 k
 perl-Digest-MD5                                               x86_64                                   2.55-439.fc31                                              fedora                                     36 k
 perl-Error                                                    noarch                                   1:0.17028-1.fc31                                           fedora                                     42 k
 perl-File-Path                                                noarch                                   2.16-439.fc31                                              fedora                                     36 k
 perl-File-Temp                                                noarch                                   1:0.230.900-439.fc31                                       fedora                                     60 k
 perl-Getopt-Long                                              noarch                                   1:2.51-1.fc31                                              fedora                                     60 k
 perl-HTTP-Tiny                                                noarch                                   0.076-439.fc31                                             fedora                                     55 k
 perl-MIME-Base64                                              x86_64                                   3.15-439.fc31                                              fedora                                     30 k
 perl-Net-SSLeay                                               x86_64                                   1.88-3.fc31                                                fedora                                    355 k
 perl-PathTools                                                x86_64                                   3.78-439.fc31                                              fedora                                     86 k
 perl-Pod-Escapes                                              noarch                                   1:1.07-439.fc31                                            fedora                                     20 k
 perl-Pod-Perldoc                                              noarch                                   3.28.01-442.fc31                                           fedora                                     85 k
 perl-Pod-Simple                                               noarch                                   1:3.39-2.fc31                                              fedora                                    214 k
 perl-Pod-Usage                                                noarch                                   4:1.69-439.fc31                                            fedora                                     32 k
 perl-Socket                                                   x86_64                                   4:2.029-4.fc31                                             fedora                                     56 k
 perl-Term-ANSIColor                                           noarch                                   4.06-440.fc31                                              fedora                                     44 k
 perl-Term-Cap                                                 noarch                                   1.17-439.fc31                                              fedora                                     22 k
 perl-TermReadKey                                              x86_64                                   2.38-4.fc31                                                fedora                                     36 k
 perl-Text-ParseWords                                          noarch                                   3.30-439.fc31                                              fedora                                     16 k
 perl-Text-Tabs+Wrap                                           noarch                                   2013.0523-439.fc31                                         fedora                                     23 k
 perl-URI                                                      noarch                                   1.76-5.fc31                                                fedora                                    108 k
 perl-Unicode-Normalize                                        x86_64                                   1.26-439.fc31                                              fedora                                     97 k
 perl-constant                                                 noarch                                   1.33-440.fc31                                              fedora                                     23 k
 perl-libnet                                                   noarch                                   3.11-440.fc31                                              fedora                                    117 k
 perl-parent                                                   noarch                                   1:0.237-439.fc31                                           fedora                                     14 k
 perl-podlators                                                noarch                                   1:4.12-2.fc31                                              fedora                                    113 k
 perl-threads                                                  x86_64                                   1:2.22-439.fc31                                            fedora                                     58 k
 perl-threads-shared                                           x86_64                                   1.60-440.fc31                                              fedora                                     44 k
 pixman                                                        x86_64                                   0.38.4-1.fc31                                              fedora                                    260 k
 rest                                                          x86_64                                   0.8.1-6.fc31                                               fedora                                     70 k
Installing weak dependencies:
 perl-IO-Socket-SSL                                            noarch                                   2.066-7.fc31                                               updates                                   238 k
 abattis-cantarell-fonts                                       noarch                                   0.111-3.fc31                                               fedora                                    257 k
 dconf                                                         x86_64                                   0.34.0-1.fc31                                              fedora                                    109 k
 gnome-keyring                                                 x86_64                                   3.34.0-1.fc31                                              fedora                                    944 k
 perl-IO-Socket-IP                                             noarch                                   0.39-440.fc31                                              fedora                                     42 k
 perl-Mozilla-CA                                               noarch                                   20180117-6.fc31                                            fedora                                     12 k


Expected results:
only git, ssh, and handful of perl things

Additional info:

Comment 1 Todd Zullinger 2020-02-19 17:40:24 UTC
The dependencies come from the libsecret credential helper.  The libsecret package added gnome-keyring as a weak dep in 4976bb0 (Recommend gnome-keyring, 2019-09-06).

You can avoid that with `dnf install --setopt=install_weak_deps=False git` for now.  I'll look at splitting out the libsecret credential now that it's got a bloated dependency set.

Comment 2 Todd Zullinger 2020-02-23 01:46:05 UTC
I pushed a change to rawhide and f32 to split out the libsecret credential helper.

I think that's also something which should percolate to f31, but probably deserves some discussion with the other git maintainers and interested parties.

When we added the libsecret credential helper I remember checking that doing so had very minimal deps (it only pulled in libsecret itself, as far as I recall).  Now that the dependency chain of libsecret has grown quite a bit, it belongs in a subpackage just like we had the for gnome-keyring credential helper.  So I view this is a bugfix.  I'm sure that some folks have come to rely on its presence and there's no good way to keep everyone happy.  If we don't split the package in f31, folks using it must wait for several months to pick up the change when f32 is released.  If we push the change to f31 as an update, those who rely on it may be surprised that the functionality disappears and requires an additional package to restore.

Anyone feel strongly that this isn't a bugfix which belongs in f31?  (It doesn't affect f30, as libsecret doesn't have the gnome-keyring dep there.)

For the moment, I did an f31 scratch build with the change here: https://koji.fedoraproject.org/koji/taskinfo?taskID=41790192

(I would have pushed that to my git copr, but we're at the start of an outage while copr is migrated from Fedora's infra cloud to AWS.)

Comment 3 Fedora Update System 2020-03-14 22:39:49 UTC
FEDORA-2020-f87c04bad1 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-f87c04bad1

Comment 4 Fedora Update System 2020-03-15 14:29:55 UTC
git-2.25.1-2.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-f87c04bad1

Comment 5 Fedora Update System 2020-03-16 15:11:50 UTC
git-2.25.1-2.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.

Comment 6 rugk 2020-03-22 15:07:16 UTC
Uhm, this came unexpected when my git pushes/pulls suddently just did not work anymore. Thankfully I could quickly find this bug/issue here, but to make others aware of that issue, I've announced that in more detail in the forum, too:
https://discussion.fedoraproject.org/t/attention-git-credential-libsecret-for-storing-git-passwords-in-the-gnome-keyring-is-now-an-extra-package/18275?u=rugk

Comment 7 Todd Zullinger 2020-03-22 17:02:39 UTC
Sorry for the trouble.  Thanks for posting to help others!


Note You need to log in before you can comment on or make changes to this bug.