Bug 1804988

Summary: Metric labels set incorrectly during build
Product: OpenShift Container Platform Reporter: Jesus M. Rodriguez <jesusr>
Component: Service CatalogAssignee: Jesus M. Rodriguez <jesusr>
Status: CLOSED WONTFIX QA Contact: Fan Jia <jfan>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 4.4   
Target Milestone: ---   
Target Release: 4.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-02-20 09:16:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1791001    

Description Jesus M. Rodriguez 2020-02-20 03:23:04 UTC
Description of problem:
Following metric labels are not set: `gitCommit` and `gitVersion`. They are returned as `gitCommit="$Format:%H$",gitVersion="v0.0.0-master+$Format:%h$"`

This is the case for openshift-service-catalog-apiserver-operator and for openshift-service-catalog-controller-manager-operator

Version-Release number of selected component (if applicable):
4.4.0

How reproducible:
Always

Steps to Reproduce:
1. Start a cluster
2. Go to metrics console
3. search for `kubernetes_build_info{job!~"kube-dns|coredns",gitVersion!="v1.17.0"}`

Actual results:
Prometheus returns metrics with invalid label values:
`gitCommit="$Format:%H$" and gitVersion="v0.0.0-master+$Format:%h$"`

Expected results:
Nothing is returned

Additional info:
Frequently happens in CI builds.

Comment 1 Jesus M. Rodriguez 2020-02-20 03:26:53 UTC
These metrics actually don't apply to OpenShift 4.5, since the svcat operators will be removed in that release.