Bug 1804988 - Metric labels set incorrectly during build
Summary: Metric labels set incorrectly during build
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Service Catalog
Version: 4.4
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 4.5.0
Assignee: Jesus M. Rodriguez
QA Contact: Fan Jia
URL:
Whiteboard:
Depends On:
Blocks: 1791001
TreeView+ depends on / blocked
 
Reported: 2020-02-20 03:23 UTC by Jesus M. Rodriguez
Modified: 2020-02-20 09:16 UTC (History)
0 users

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-02-20 09:16:35 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Jesus M. Rodriguez 2020-02-20 03:23:04 UTC
Description of problem:
Following metric labels are not set: `gitCommit` and `gitVersion`. They are returned as `gitCommit="$Format:%H$",gitVersion="v0.0.0-master+$Format:%h$"`

This is the case for openshift-service-catalog-apiserver-operator and for openshift-service-catalog-controller-manager-operator

Version-Release number of selected component (if applicable):
4.4.0

How reproducible:
Always

Steps to Reproduce:
1. Start a cluster
2. Go to metrics console
3. search for `kubernetes_build_info{job!~"kube-dns|coredns",gitVersion!="v1.17.0"}`

Actual results:
Prometheus returns metrics with invalid label values:
`gitCommit="$Format:%H$" and gitVersion="v0.0.0-master+$Format:%h$"`

Expected results:
Nothing is returned

Additional info:
Frequently happens in CI builds.

Comment 1 Jesus M. Rodriguez 2020-02-20 03:26:53 UTC
These metrics actually don't apply to OpenShift 4.5, since the svcat operators will be removed in that release.


Note You need to log in before you can comment on or make changes to this bug.