Bug 1805184

Summary: Cannot set bond options to `updelay=0` with `miimon=0`
Product: Red Hat Enterprise Linux 8 Reporter: Gris Ge <fge>
Component: NetworkManagerAssignee: Antonio Cardace <acardace>
Status: CLOSED ERRATA QA Contact: Desktop QE <desktop-qa-list>
Severity: high Docs Contact:
Priority: high    
Version: 8.2CC: acardace, atragler, bgalvani, danken, edwardh, lrintel, pasik, rkhan, sukulkar, thaller, till, vbenes
Target Milestone: rc   
Target Release: 8.2   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: NetworkManager-1.25.1-1.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-11-04 01:49:00 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1738136, 1805205    

Description Gris Ge 2020-02-20 13:10:10 UTC 
Description of problem:

When nmstate try to apply bonding options to connection profile,
got failure:

nm-connection-error-quark: bond.options: 'updelay' option requires 'miimon' option to be set (7)

But in kernel, its default value for a bond is updelay=0 miimon=0 which is legal.

Version-Release number of selected component (if applicable):
NetworkManager-1.22.8-1.el8.x86_64

How reproducible:
100%

Steps to Reproduce:
1. nmcli c add type bond ifname bond99 bond.options updelay=0,miimon=0,mode=0
2.
3.

Actual results:

Error: Failed to add 'bond-bond99' connection: bond.options: 'updelay' option requires 'miimon' option to be set

Expected results:
No failure.

Additional info:

I think NM is overkill on this bond option check. It's hard for NM to track the
restrictions of kernel.
Comment 1 Antonio Cardace 2020-02-20 14:41:55 UTC 
MR with the fix waiting for review: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/merge_requests/424
Comment 2 Antonio Cardace 2020-02-28 14:49:51 UTC 
Fixed upstream with commit 50da785be14ac976f909b29766195baaa49e1934 and backported to branch nm-1-22
Comment 4 Gris Ge 2020-03-03 11:52:21 UTC 
nmstate has workaround in upstream master branch: https://github.com/nmstate/nmstate/pull/839
Comment 5 Thomas Haller 2020-04-07 15:41:40 UTC 
missed rhel-8.2
Comment 8 Vladimir Benes 2020-06-22 10:04:09 UTC 
test case added:
https://gitlab.freedesktop.org/NetworkManager/NetworkManager-ci/-/merge_requests/583
Comment 9 Vladimir Benes 2020-06-22 10:05:30 UTC 
test case added (correct link):
https://gitlab.freedesktop.org/NetworkManager/NetworkManager-ci/-/merge_requests/582
Comment 12 errata-xmlrpc 2020-11-04 01:49:00 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (NetworkManager bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4499