Bug 1805673

Summary: tsb operator should NOT be scheduled to the Windows worker
Product: OpenShift Container Platform Reporter: Cuiping HUO <chuo>
Component: Service BrokerAssignee: Jesus M. Rodriguez <jesusr>
Status: CLOSED ERRATA QA Contact: Cuiping HUO <chuo>
Severity: high Docs Contact:
Priority: high    
Version: 4.4CC: aos-bugs, chezhang, jesusr, jfan, jiazha
Target Milestone: ---   
Target Release: 4.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-07-13 17:16:52 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1805672    

Description Cuiping HUO 2020-02-21 10:57:49 UTC
Description of problem:
Now, OCP supports the Windows worker. But, the tsb operator doesn't. 
So, we should set the `NodeSelector` in their deployment field of CSV to avoid the failure on the Windows worker.

Version-Release number of selected component (if applicable):
4.4.0-0.nightly-2020-02-16-221315

How reproducible:
always

Steps to Reproduce:
1. Install OCP with a Windows worker.

$ oc get nodes --show-labels |grep windows
ip-10-0-38-164.us-east-2.compute.internal    Ready                      worker   6h52m   v1.16.2   beta.kubernetes.io/arch=amd64,beta.kubernetes.io/instance-type=m5a.large,beta.kubernetes.io/os=windows,failure-domain.beta.kubernetes.io/region=us-east-2,failure-domain.beta.kubernetes.io/zone=us-east-2c,kubernetes.io/arch=amd64,kubernetes.io/hostname=ec2amaz-ldli9dr,kubernetes.io/os=windows,node-role.kubernetes.io/worker=,node.openshift.io/os_id=Windows

2. Install a tsb operator and check its deployment. 

Actual results:
There is no "NodeSelector" specific in the Deployment field of their CSV.

$ oc get csv -n openshift-template-service-broker openshifttemplateservicebrokeroperator.4.4.0-202002111717 -o yaml| grep -i "NodeSelector"



Expected results:
In order to run failure on the Windows worker. We should set the "NodeSelector" to select the Linus worker in the Deployment field of their CSV. For example:
$ oc get deployment -n openshift-marketplace certified-operators -o yaml | grep -i "NodeSelector" -A 1
      nodeSelector:
        beta.kubernetes.io/os: linux

Additional info:

Comment 1 Cuiping HUO 2020-02-24 06:31:01 UTC
@jesusr
Is this bug only use for cherry-pick fixing back to release 4.4.0, because tsb is planning to remove in 4.5?

Comment 2 Jesus M. Rodriguez 2020-02-24 14:55:08 UTC
@chuo, yes this is a tracking bug for 4.5. There is no TSB in 4.5. Testing instructions for 4.5 are to verify that TSB is no longer installed.

Comment 5 Cuiping HUO 2020-02-28 07:49:00 UTC
As this is a tracking bug in 4.5 for https://bugzilla.redhat.com/show_bug.cgi?id=1805672 and 1805672 is verified, so change this bug to VERIFIED also.

Comment 7 errata-xmlrpc 2020-07-13 17:16:52 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409