Bug 1805870
| Summary: | Review Request: sil-apparatus-fonts - A font family for rendering Greek & Hebrew biblical texts | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nicolas Mailhot <nicolas.mailhot> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fonts-bugs, package-review, panemade, petersen, tagoh |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-02-25 00:13:45 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Nicolas Mailhot
2020-02-21 16:49:58 UTC
*** Bug 1805869 has been marked as a duplicate of this bug. *** ERROR: 'Cannot parse Source0 url https://scripts.sil.org/cms/scripts/render_download.php?format=file&media_id=AppSIL1.0.zip&filename=%{archivename.zip}#/%{archivename.zip}' debug log says 02-23 12:23 root DEBUG ReviewError: 'Cannot parse Source0 url https://scripts.sil.org/cms/scripts/render_download.php?format=file&media_id=AppSIL1.0.zip&filename=%{archivename.zip}#/%{archivename.zip}' Traceback (most recent call last): File "/usr/lib/python3.8/site-packages/FedoraReview/spec_file.py", line 171, in _get_sources result[tag] = self.spec.sourceHeader.format(unquote(url)) _rpm.error: unknown tag: "archivename.zip" Sorry about that, I messed up the last refactoring of SIL specs in that case (Apparatus is one of their oldest projects and it is not published the same way as others)
copr, mock, rpmbuild & spectool are quite happy with the spec except the source is named %{archivename.sip} (not really what you want it to be).
Please use:
https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01249599-sil-apparatus-fonts/sil-apparatus-fonts.spec
https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01249599-sil-apparatus-fonts/sil-apparatus-fonts-1.0-3.fc33.noarch.rpm
They should work better.
Review:
I downloaded manually required srpm file and did below review of this package.
This package follows new fonts packaging guidelines.
Rpmlint
-------
Checking: sil-apparatus-fonts-1.0-1.fc33.noarch.rpm
sil-apparatus-fonts-1.0-1.fc33.src.rpm
sil-apparatus-fonts.noarch: W: invalid-url URL: https://software.sil.org/ApparatusSIL/ HTTP Error 404: Not Found
sil-apparatus-fonts.src: W: invalid-url URL: https://software.sil.org/ApparatusSIL/ HTTP Error 404: Not Found
2 packages and 0 specfiles checked; 0 errors, 2 warnings.
Source checksums
----------------
https://scripts.sil.org/cms/scripts/render_download.php?format=file&media_id=AppSIL1.0.zip&filename=ApparatusSIL.zip#/ApparatusSIL.zip :
CHECKSUM(SHA256) this package : 0d8e3143b9c46c97916ab2cf85ae2187fe33b9b40859567a5524266dd58581bc
CHECKSUM(SHA256) upstream package : 0d8e3143b9c46c97916ab2cf85ae2187fe33b9b40859567a5524266dd58581bc
Requires
--------
sil-apparatus-fonts (rpmlib, GLIBC filtered):
config(sil-apparatus-fonts)
fontpackages-filesystem
Provides
--------
sil-apparatus-fonts:
config(sil-apparatus-fonts)
font(apparatussil)
metainfo()
metainfo(org.fedoraproject.sil-apparatus-fonts.metainfo.xml)
sil-apparatus-fonts
All other things like license, config, metainfo files looks good.
APPROVED.
Also fixed the URL Thanks for the review! https://pagure.io/releng/fedora-scm-requests/issue/22406 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/sil-apparatus-fonts Done for F32 & F33. Thanks Parag and Gwyn. |