Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01240862-sil-apparatus-fonts/sil-apparatus-fonts.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01240862-sil-apparatus-fonts/sil-apparatus-fonts-1.0-1.fc33.src.rpm Description: The Apparatus SIL font family was designed to provide most of the symbols needed to reproduce the textual apparatus found in major editions of Greek & Hebrew biblical texts. It is based on SIL Charis, a font family designed for optimum clarity and compactness when printed at small point sizes. This assures that both Charis SIL and Apparatus SIL can be used together in documents with a consistency of style. Most lines of text in the apparatus can be reproduced by combining the Greek and Hebrew fonts, transliteration (using a font such as Charis SIL), and the Apparatus SIL font. Fedora Account System Username: nim One of SIL’s Non-Roman Script Initiative font families https://scripts.sil.org/cms/scripts/page.php?site_id=nrsi&id=Home SIL is a specialist of rare human scripts and contributes its expertise to the Unicode consortium. The objective is to get 100% of SIL’s font catalog in Fedora to improve our i18n coverage. Due to $#@= variations on how SIL publishes its fonts, the spec uses some SIL-specific macros to hide those variations and limit the changes between the specs of SIL fonts. The packaging conforms to https://pagure.io/packaging-committee/issue/935 as approved by FPC on 2020-02-13. It is one of the test packages that were used to refine the new packaging guidelines https://copr.fedorainfracloud.org/coprs/nim/fonts-rpm-macros/ The new fonts packaging build chain is now live in koji. For example: https://koji.fedoraproject.org/koji/buildinfo?buildID=1468243 If the review is fast enough the package may make the FC32 100% Code Complete Deadline (2020-02-25) https://fedorapeople.org/groups/schedule/f-32/f-32-key-tasks.html
*** Bug 1805869 has been marked as a duplicate of this bug. ***
ERROR: 'Cannot parse Source0 url https://scripts.sil.org/cms/scripts/render_download.php?format=file&media_id=AppSIL1.0.zip&filename=%{archivename.zip}#/%{archivename.zip}' debug log says 02-23 12:23 root DEBUG ReviewError: 'Cannot parse Source0 url https://scripts.sil.org/cms/scripts/render_download.php?format=file&media_id=AppSIL1.0.zip&filename=%{archivename.zip}#/%{archivename.zip}' Traceback (most recent call last): File "/usr/lib/python3.8/site-packages/FedoraReview/spec_file.py", line 171, in _get_sources result[tag] = self.spec.sourceHeader.format(unquote(url)) _rpm.error: unknown tag: "archivename.zip"
Sorry about that, I messed up the last refactoring of SIL specs in that case (Apparatus is one of their oldest projects and it is not published the same way as others) copr, mock, rpmbuild & spectool are quite happy with the spec except the source is named %{archivename.sip} (not really what you want it to be). Please use: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01249599-sil-apparatus-fonts/sil-apparatus-fonts.spec https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01249599-sil-apparatus-fonts/sil-apparatus-fonts-1.0-3.fc33.noarch.rpm They should work better.
Review: I downloaded manually required srpm file and did below review of this package. This package follows new fonts packaging guidelines. Rpmlint ------- Checking: sil-apparatus-fonts-1.0-1.fc33.noarch.rpm sil-apparatus-fonts-1.0-1.fc33.src.rpm sil-apparatus-fonts.noarch: W: invalid-url URL: https://software.sil.org/ApparatusSIL/ HTTP Error 404: Not Found sil-apparatus-fonts.src: W: invalid-url URL: https://software.sil.org/ApparatusSIL/ HTTP Error 404: Not Found 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Source checksums ---------------- https://scripts.sil.org/cms/scripts/render_download.php?format=file&media_id=AppSIL1.0.zip&filename=ApparatusSIL.zip#/ApparatusSIL.zip : CHECKSUM(SHA256) this package : 0d8e3143b9c46c97916ab2cf85ae2187fe33b9b40859567a5524266dd58581bc CHECKSUM(SHA256) upstream package : 0d8e3143b9c46c97916ab2cf85ae2187fe33b9b40859567a5524266dd58581bc Requires -------- sil-apparatus-fonts (rpmlib, GLIBC filtered): config(sil-apparatus-fonts) fontpackages-filesystem Provides -------- sil-apparatus-fonts: config(sil-apparatus-fonts) font(apparatussil) metainfo() metainfo(org.fedoraproject.sil-apparatus-fonts.metainfo.xml) sil-apparatus-fonts All other things like license, config, metainfo files looks good. APPROVED.
Also fixed the URL Thanks for the review! https://pagure.io/releng/fedora-scm-requests/issue/22406
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/sil-apparatus-fonts
Done for F32 & F33. Thanks Parag and Gwyn.