Bug 1805926
| Summary: | Review Request: sil-mondulkiri-extra-fonts - Extra Khmer script font families from the SIL Mondulkiri project | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nicolas Mailhot <nicolas.mailhot> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fonts-bugs, package-review, panemade, petersen, tagoh |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-02-25 00:02:12 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Nicolas Mailhot
2020-02-21 17:36:54 UTC
Review: Not going for full package review. This package follows new fonts packaging guidelines. Rpmlint ------- sil-busra-bunong-fonts.noarch: W: spelling-error %description -l en_US coengs -> coverings sil-busra-diagnostic-fonts.noarch: W: spelling-error %description -l en_US xspace -> space, x space sil-busra-diagnostic-fonts.noarch: W: spelling-error %description -l en_US coengs -> coverings sil-busra-dot-fonts.noarch: W: spelling-error %description -l en_US codepoint -> code point, code-point, codependent sil-busra-moe-fonts.noarch: W: spelling-error %description -l en_US coeng -> conger sil-mondulkiri-extra-fonts-all.noarch: W: spelling-error %description -l en_US metapackage -> meta package, meta-package, prepackage sil-mondulkiri-extra-fonts-all.noarch: W: no-documentation sil-mondulkiri-extra-fonts-doc.noarch: W: summary-not-capitalized C sil-mondulkiri-extra-fonts optional documentation files sil-mondulkiri-extra-fonts-doc.noarch: E: description-line-too-long C This package provides optional documentation files shipped with sil-mondulkiri-extra-fonts. sil-ratanakiri-fonts.noarch: W: spelling-error %description -l en_US coengs -> coverings sil-ratanakiri-fonts.noarch: W: spelling-error %description -l en_US coeng -> conger 12 packages and 0 specfiles checked; 1 errors, 10 warnings. Source checksums ---------------- https://scripts.sil.org/cms/scripts/render_download.php?format=file&media_id=Mondulkiri-5.300&filename=Mondulkiri-5.300.zip#/Mondulkiri-5.300.zip : CHECKSUM(SHA256) this package : 4ff38760e48f3185c515088d91bc9e6a17402cbb3be316c06681c231db580f88 CHECKSUM(SHA256) upstream package : 4ff38760e48f3185c515088d91bc9e6a17402cbb3be316c06681c231db580f88 All other things like license, config, metainfo files looks good. Issues: 1) Fix Summary not capitalized and description not wrapped to 80 characters. 2) fedora-review failed to install generated packages in mock. But let's not block this review here. Tested manually installing generated packages. Working fine. APPROVED. Thanks for the review! I fixed the spelling bits rpmlint did not like in the macro templates (not sure this is worth a new release) https://pagure.io/fonts-rpm-macros/c/5f50c715c3b6a3dabb7371d33e7c4fd9e4e12b7c https://pagure.io/releng/fedora-scm-requests/issue/22385 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/sil-mondulkiri-extra-fonts Done for F32 & F33. Thanks Parag and Gwyn. |