Spec URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01240874-sil-mondulkiri-extra-fonts/sil-mondulkiri-extra-fonts.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01240874-sil-mondulkiri-extra-fonts/sil-mondulkiri-extra-fonts-5.300-1.fc33.src.rpm Description: The Mondulkiri font families provide Unicode support for the Khmer script. “Mondulkiri” and “Ratanakiri” are the names of two provinces in north-eastern Cambodia, Busra and Oureang are names of places in Mondulkiri province. Fedora Account System Username: nim One of SIL’s Non-Roman Script Initiative font families https://scripts.sil.org/cms/scripts/page.php?site_id=nrsi&id=Home SIL is a specialist of rare human scripts and contributes its expertise to the Unicode consortium. The objective is to get 100% of SIL’s font catalog in Fedora to improve our i18n coverage. Due to $#@= variations on how SIL publishes its fonts, the spec uses some SIL-specific macros to hide those variations and limit the changes between the specs of SIL fonts. The packaging conforms to https://pagure.io/packaging-committee/issue/935 as approved by FPC on 2020-02-13. It is one of the test packages that were used to refine the new packaging guidelines https://copr.fedorainfracloud.org/coprs/nim/fonts-rpm-macros/ The new fonts packaging build chain is now live in koji. For example: https://koji.fedoraproject.org/koji/buildinfo?buildID=1468243 If the review is fast enough the package may make the FC32 100% Code Complete Deadline (2020-02-25) https://fedorapeople.org/groups/schedule/f-32/f-32-key-tasks.html
Review: Not going for full package review. This package follows new fonts packaging guidelines. Rpmlint ------- sil-busra-bunong-fonts.noarch: W: spelling-error %description -l en_US coengs -> coverings sil-busra-diagnostic-fonts.noarch: W: spelling-error %description -l en_US xspace -> space, x space sil-busra-diagnostic-fonts.noarch: W: spelling-error %description -l en_US coengs -> coverings sil-busra-dot-fonts.noarch: W: spelling-error %description -l en_US codepoint -> code point, code-point, codependent sil-busra-moe-fonts.noarch: W: spelling-error %description -l en_US coeng -> conger sil-mondulkiri-extra-fonts-all.noarch: W: spelling-error %description -l en_US metapackage -> meta package, meta-package, prepackage sil-mondulkiri-extra-fonts-all.noarch: W: no-documentation sil-mondulkiri-extra-fonts-doc.noarch: W: summary-not-capitalized C sil-mondulkiri-extra-fonts optional documentation files sil-mondulkiri-extra-fonts-doc.noarch: E: description-line-too-long C This package provides optional documentation files shipped with sil-mondulkiri-extra-fonts. sil-ratanakiri-fonts.noarch: W: spelling-error %description -l en_US coengs -> coverings sil-ratanakiri-fonts.noarch: W: spelling-error %description -l en_US coeng -> conger 12 packages and 0 specfiles checked; 1 errors, 10 warnings. Source checksums ---------------- https://scripts.sil.org/cms/scripts/render_download.php?format=file&media_id=Mondulkiri-5.300&filename=Mondulkiri-5.300.zip#/Mondulkiri-5.300.zip : CHECKSUM(SHA256) this package : 4ff38760e48f3185c515088d91bc9e6a17402cbb3be316c06681c231db580f88 CHECKSUM(SHA256) upstream package : 4ff38760e48f3185c515088d91bc9e6a17402cbb3be316c06681c231db580f88 All other things like license, config, metainfo files looks good. Issues: 1) Fix Summary not capitalized and description not wrapped to 80 characters. 2) fedora-review failed to install generated packages in mock. But let's not block this review here. Tested manually installing generated packages. Working fine. APPROVED.
Thanks for the review! I fixed the spelling bits rpmlint did not like in the macro templates (not sure this is worth a new release) https://pagure.io/fonts-rpm-macros/c/5f50c715c3b6a3dabb7371d33e7c4fd9e4e12b7c https://pagure.io/releng/fedora-scm-requests/issue/22385
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/sil-mondulkiri-extra-fonts
Done for F32 & F33. Thanks Parag and Gwyn.