Bug 1805962
Summary: | Review Request: sil-tai-heritage-pro-fonts - A traditional style Tai Viet script font family | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Nicolas Mailhot <nicolas.mailhot> |
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fonts-bugs, package-review, panemade, petersen, tagoh |
Target Milestone: | --- | Flags: | panemade:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2020-02-24 23:54:27 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Nicolas Mailhot
2020-02-21 18:22:03 UTC
Review: Not going for full package review. This package follows new fonts packaging guidelines. Rpmlint ------- Checking: sil-tai-heritage-pro-fonts-2.600-1.fc33.noarch.rpm sil-tai-heritage-pro-fonts-2.600-1.fc33.src.rpm sil-tai-heritage-pro-fonts.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/sil-tai-heritage-pro-fonts/developer/RegressionTestReferenceHistory.txt sil-tai-heritage-pro-fonts.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/sil-tai-heritage-pro-fonts/developer/TaiHeritagePro-workflow.txt 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Source checksums ---------------- https://github.com/silnrsi/font-taiheritagepro/releases/download/v2.600/TaiHeritagePro-2.600.tar.xz : CHECKSUM(SHA256) this package : 72ec66a7ac126f2bff66f2f9957923214d296f69843034fc3f27eabc036b7031 CHECKSUM(SHA256) upstream package : 72ec66a7ac126f2bff66f2f9957923214d296f69843034fc3f27eabc036b7031 Requires -------- sil-tai-heritage-pro-fonts (rpmlib, GLIBC filtered): config(sil-tai-heritage-pro-fonts) fontpackages-filesystem Provides -------- sil-tai-heritage-pro-fonts: config(sil-tai-heritage-pro-fonts) font(taiheritagepro) metainfo() metainfo(org.fedoraproject.sil-tai-heritage-pro-fonts.metainfo.xml) sil-tai-heritage-pro-fonts All other things like license, config, metainfo files looks good. Issues: 1) Fix the rpmlint warning "wrong-file-end-of-line-encoding" before import of this package. APPROVED. Fixed! Thanks for the review! https://pagure.io/releng/fedora-scm-requests/issue/22391 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/sil-tai-heritage-pro-fonts Done for F32 & F33. Thanks Parag and Gwyn. |