Spec URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01240880-sil-tai-heritage-pro-fonts/sil-tai-heritage-pro-fonts.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01240880-sil-tai-heritage-pro-fonts/sil-tai-heritage-pro-fonts-2.600-1.fc33.src.rpm Description: The Tai people of northwestern Vietnam and surrounding areas have a long tradition of literacy in the Tai Viet script. Tai Heritage Pro reflects the traditional style of this script. Fedora Account System Username: nim One of SIL’s Non-Roman Script Initiative font families https://scripts.sil.org/cms/scripts/page.php?site_id=nrsi&id=Home SIL is a specialist of rare human scripts and contributes its expertise to the Unicode consortium. The objective is to get 100% of SIL’s font catalog in Fedora to improve our i18n coverage. Due to $#@= variations on how SIL publishes its fonts, the spec uses some SIL-specific macros to hide those variations and limit the changes between the specs of SIL fonts. The packaging conforms to https://pagure.io/packaging-committee/issue/935 as approved by FPC on 2020-02-13. It is one of the test packages that were used to refine the new packaging guidelines https://copr.fedorainfracloud.org/coprs/nim/fonts-rpm-macros/ The new fonts packaging build chain is now live in koji. For example: https://koji.fedoraproject.org/koji/buildinfo?buildID=1468243 If the review is fast enough the package may make the FC32 100% Code Complete Deadline (2020-02-25) https://fedorapeople.org/groups/schedule/f-32/f-32-key-tasks.html
Review: Not going for full package review. This package follows new fonts packaging guidelines. Rpmlint ------- Checking: sil-tai-heritage-pro-fonts-2.600-1.fc33.noarch.rpm sil-tai-heritage-pro-fonts-2.600-1.fc33.src.rpm sil-tai-heritage-pro-fonts.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/sil-tai-heritage-pro-fonts/developer/RegressionTestReferenceHistory.txt sil-tai-heritage-pro-fonts.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/sil-tai-heritage-pro-fonts/developer/TaiHeritagePro-workflow.txt 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Source checksums ---------------- https://github.com/silnrsi/font-taiheritagepro/releases/download/v2.600/TaiHeritagePro-2.600.tar.xz : CHECKSUM(SHA256) this package : 72ec66a7ac126f2bff66f2f9957923214d296f69843034fc3f27eabc036b7031 CHECKSUM(SHA256) upstream package : 72ec66a7ac126f2bff66f2f9957923214d296f69843034fc3f27eabc036b7031 Requires -------- sil-tai-heritage-pro-fonts (rpmlib, GLIBC filtered): config(sil-tai-heritage-pro-fonts) fontpackages-filesystem Provides -------- sil-tai-heritage-pro-fonts: config(sil-tai-heritage-pro-fonts) font(taiheritagepro) metainfo() metainfo(org.fedoraproject.sil-tai-heritage-pro-fonts.metainfo.xml) sil-tai-heritage-pro-fonts All other things like license, config, metainfo files looks good. Issues: 1) Fix the rpmlint warning "wrong-file-end-of-line-encoding" before import of this package. APPROVED.
Fixed! Thanks for the review! https://pagure.io/releng/fedora-scm-requests/issue/22391
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/sil-tai-heritage-pro-fonts
Done for F32 & F33. Thanks Parag and Gwyn.