Bug 1805987

Summary:	[4.5]Multus should not cause machine to go not ready when a default SDN is updated
Product:	OpenShift Container Platform	Reporter:	Douglas Smith <dosmith>
Component:	Networking	Assignee:	Douglas Smith <dosmith>
Networking sub component:	multus	QA Contact:	Weibin Liang <weliang>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	unspecified
Priority:	unspecified	CC:	aconstan, danw, weliang, zzhao
Version:	4.4
Target Milestone:	---
Target Release:	4.5.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:	1805774	Environment:
Last Closed:	2020-08-04 18:01:21 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1805774

Description Douglas Smith 2020-02-21 19:17:34 UTC

+++ This bug was initially created as a clone of Bug #1805774 +++

This bug was initially created as a copy of Bug #1805444

I am copying this bug because: 



Description of problem: This was discovered in the investigation of https://bugzilla.redhat.com/show_bug.cgi?id=1793635 (for upgrades)

The fix includes using the Multus "readinessindicatorfile".

How reproducible: During upgrades.

--- Additional comment from Douglas Smith on 2020-02-21 16:21:57 UTC ---

PR @ https://github.com/openshift/multus-cni/pull/47

I think the only validation that can be done would be to spin up a cluster that includes that PR and enter the Multus damonset and see if the file /entrypoint.sh contains the string MULTUS_READINESS_INDICATOR_FILE if that's the case, I believe it should be (mostly) verified -- that code won't be exercised until the associate CNOs merge (and they can't pass CI until that code is there, e.g. that string I mentioned)

Comment 1 Weibin Liang 2020-02-25 14:27:59 UTC

Fixing https://github.com/openshift/multus-cni/pull/47 is merged v4.5 branch, v4.5 nightly code is still not available.

Comment 2 zhaozhanqi 2020-02-26 07:02:41 UTC

Change the target version to 4.5 according comment 1. please change it back if I'm wrong

Comment 5 zhaozhanqi 2020-03-06 09:32:24 UTC

verified this bug 4.5.0-0.nightly-2020-03-05-190442

#oc describe pod multus-4bq59 -n openshift-multus| grep readiness-indicator-file
      --readiness-indicator-file=/var/run/multus/cni/net.d/80-openshift-network.conf

Comment 7 errata-xmlrpc 2020-08-04 18:01:21 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.5 image release advisory), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409