Bug 1809005

Summary:	No "nodeSelector=kubernetes.io/os: linux" label for image registry and image registry operator
Product:	OpenShift Container Platform	Reporter:	Wenjing Zheng <wzheng>
Component:	Image Registry	Assignee:	Ricardo Maraschini <rmarasch>
Status:	CLOSED ERRATA	QA Contact:	Wenjing Zheng <wzheng>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4.1.z	CC:	aos-bugs, rmarasch
Target Milestone:	---
Target Release:	4.5.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	Cause: Operator is not setting nodeSelector label on image registry created resources. Consequence: This could have affected us in the future as we were not specifying in what nodes our resources can run, we could end up running the registry over unsupported platforms. Fix: Added the missing label to created resources. Result: It is possible to see the label on the created resources.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-08-04 18:02:52 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Wenjing Zheng 2020-03-02 09:13:46 UTC

Description of problem:
There is no "nodeSelector=kubernetes.io/os: linux" label for image registry resources

Version-Release number of selected component (if applicable):
4.4.0-0.nightly-2020-03-01-215047

How reproducible:
Always

Steps to Reproduce:
1.Check image registry related resources, like cluster-image-registry-operator deployment and image-registry deployment
2.
3.

Actual results:
There is no label to indicates they cannot be scheduled to windows node

Expected results:
Should add a label

Additional info:

Comment 4 Wenjing Zheng 2020-05-13 09:19:54 UTC

I can see below nodeselector in image-registry deployment, but cannot see it in cluster-image-registry-operator deployment:
      nodeSelector:
        kubernetes.io/os: linux

Is it by design?

Comment 5 Ricardo Maraschini 2020-05-13 12:48:38 UTC

Yes, it is by design as per https://github.com/openshift/cluster-image-registry-operator/pull/518#discussion_r408918009

Comment 6 Wenjing Zheng 2020-05-14 08:46:38 UTC

Verified on 4.5.0-0.nightly-2020-05-13-221558:
     nodeSelector:
        kubernetes.io/os: linux

Comment 8 errata-xmlrpc 2020-08-04 18:02:52 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.5 image release advisory), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409