Bug 1809936

Summary:	Disk interfaces of created VMs should present errors or warnings if they aren't valid or recommended
Product:	OpenShift Container Platform	Reporter:	Ido Rosenzwig <irosenzw>
Component:	Console Kubevirt Plugin	Assignee:	Ido Rosenzwig <irosenzw>
Status:	CLOSED ERRATA	QA Contact:	Nelly Credi <ncredi>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	4.3.0	CC:	aos-bugs, gouyang, ncredi, tjelinek
Target Milestone:	---
Target Release:	4.4.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1803780	Environment:
Last Closed:	2020-05-04 11:44:29 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1803780
Bug Blocks:

Description Ido Rosenzwig 2020-03-04 09:07:02 UTC

+++ This bug was initially created as a clone of Bug #1803780 +++

Description of problem:
on the `Disks` tab on a created VM details view, disk interface errors and warnings should appear like in the wizard.

If a VM is configured to use a disk with invalid or not recommended bus type the user should be warned.


Version-Release number of selected component (if applicable):
4.3

How reproducible:
100%

Steps to Reproduce:
1. Create a VM using the wizard with 'Windows' OS and 'url' or 'container' source
   In the storage tab verify you cannot pick 'scsi' as the interface
2. Go to the 'Virtual Machines' tab and click the VM you just created.
3. go to the Disks tab
4. Edit the root disk 
5. 'scsi' option is available for the interface although it is not allowed.
6. If you pick SATA no warning message is presented although it's not recommended bus type

Actual results:
Non-valid bus type can be picked in modal when editing or adding disk
No errors or warning appear in the modal or the disks table in the disks tab

Expected results:
Only valid and not recommended bus types can be picked in the modal when editing or adding disk
Errors and warnings should be visible if there is a problem.


Additional info:
The user can always use invalid disks if he will edit the VM yaml manually using the YAML tab, as we don't want to prevent the user completely from using what he wants.

Comment 3 Guohua Ouyang 2020-03-05 05:25:48 UTC

Not fixed on 4.4.0-0.nightly-2020-03-02-011520.

Now it's sata and scsi are recommended by default. Select one of them and click the list again, the other two become recommended.

Comment 4 Tomas Jelinek 2020-03-05 09:31:59 UTC

moving back to on_qa - it was built 4th of march, the 4.4.0-0.nightly-2020-03-02-011520 is from 2nd of march so the fix was not yet there.

Comment 5 Guohua Ouyang 2020-03-12 02:38:13 UTC

verified on 4.4.0-0.nightly-2020-03-06-170328.
Now VirtIO is recommended and if sata is selected, a warning is showing.

Comment 7 errata-xmlrpc 2020-05-04 11:44:29 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:0581