Bug 1811177
| Summary: | Review Request: golang-github-aliyun-credentials - Alibaba Cloud (Aliyun) Credentials for Go | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Brandon Perkins <bperkins> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <eclipseo> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | eclipseo, package-review |
| Target Milestone: | --- | Flags: | eclipseo:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-08-03 20:44:46 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1811173, 1811174 | ||
| Bug Blocks: | 1811183 | ||
|
Description
Brandon Perkins
2020-03-06 18:51:39 UTC
Spec URL: https://raw.githubusercontent.com/bdperkin/aliyun/master/SPECS/golang-github-aliyun-credentials.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/bdperkin/aliyun/srpm-builds/01293784/golang-github-aliyun-credentials-0.0.1-1.fc31.src.rpm Successful copr build: https://copr.fedorainfracloud.org/coprs/bdperkin/aliyun/build/01293784/ Changelog: * Wed Mar 04 2020 Brandon Perkins <bperkins> - 0.0.1-1 - Enable check stage - Update to version 0.0.1 - Add golang(github.com/alibabacloud-go/tea/tea) BuildRequires * Fri Nov 22 2019 Brandon Perkins <bperkins> - 0-0.1.20191122gitc03d72d - Initial package - You seem to be confused about how conditionals work, please read https://rpm.org/user_doc/conditional_builds.html %bcond_with disables something by default whereas %bcond_without enables something by default. So write: %bcond_without check so enable checks. - Bump to 0.0.3 - There's a test error due to a change in *Go 1.14*, now URL are between quotes. Report it upstream and patch it locally with sed in %prep for now. --- FAIL: Test_doaction (0.00s) credential_test.go:182: Error Trace: credential_test.go:182 Error: Not equal: expected: "parse # #%gfdf: invalid URL escape \"%gf\"" actual : "parse \"# #%gfdf\": invalid URL escape \"%gf\"" Diff: --- Expected +++ Actual @@ -1 +1 @@ -parse # #%gfdf: invalid URL escape "%gf" +parse "# #%gfdf": invalid URL escape "%gf" Test: Test_doaction FAIL sed -i 's|parse # #%%gfdf:|parse "# #%%gfdf":|' credentials/credential_test.go - License ok - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Spec URL: https://raw.githubusercontent.com/bdperkin/aliyun/master/SPECS/golang-github-aliyun-credentials.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/9154/48199154/golang-github-aliyun-credentials-1.1.0-1.fc33.src.rpm Changes: - Update to version 1.1.0 (#1811177) - Enable check stage - Include patch for https://github.com/aliyun/credentials-go/pull/22 - Clean changelog Spec URL: https://raw.githubusercontent.com/bdperkin/aliyun/master/SPECS/golang-github-aliyun-credentials.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/8725/48378725/golang-github-aliyun-credentials-1.1.1-1.fc33.src.rpm Changes: - Update to version 1.1.1 (#1811177) - Remove patch for fixed https://github.com/aliyun/credentials-go/pull/22 - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Package approved. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-aliyun-credentials CLOSED. In Rawhide (f33). |