Bug 1811177 - Review Request: golang-github-aliyun-credentials - Alibaba Cloud (Aliyun) Credentials for Go
Summary: Review Request: golang-github-aliyun-credentials - Alibaba Cloud (Aliyun) Cre...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1811173 1811174
Blocks: 1811183
TreeView+ depends on / blocked
 
Reported: 2020-03-06 18:51 UTC by Brandon Perkins
Modified: 2020-08-03 20:44 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-08-03 20:44:46 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description Brandon Perkins 2020-03-06 18:51:39 UTC
Spec URL: https://raw.githubusercontent.com/bdperkin/aliyun/master/SPECS/golang-github-aliyun-credentials.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/bdperkin/aliyun/srpm-builds/01291473/golang-github-aliyun-credentials-0.0.1-1.fc31.src.rpm
Description: 
Alibaba Cloud Credentials for Go.
Fedora Account System Username: bdperkin
Note: These are my first packages and I need a sponsor.
Successful copr build: https://copr.fedorainfracloud.org/coprs/bdperkin/aliyun/build/01291473/

Comment 1 Brandon Perkins 2020-03-10 12:46:30 UTC
Spec URL: https://raw.githubusercontent.com/bdperkin/aliyun/master/SPECS/golang-github-aliyun-credentials.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/bdperkin/aliyun/srpm-builds/01293784/golang-github-aliyun-credentials-0.0.1-1.fc31.src.rpm
Successful copr build: https://copr.fedorainfracloud.org/coprs/bdperkin/aliyun/build/01293784/
Changelog:
* Wed Mar 04 2020 Brandon Perkins <bperkins> - 0.0.1-1
- Enable check stage
- Update to version 0.0.1
- Add golang(github.com/alibabacloud-go/tea/tea) BuildRequires

* Fri Nov 22 2019 Brandon Perkins <bperkins> - 0-0.1.20191122gitc03d72d
- Initial package

Comment 2 Robert-André Mauchin 🐧 2020-03-24 20:51:49 UTC
 - You seem to be confused about how conditionals work, please read https://rpm.org/user_doc/conditional_builds.html

%bcond_with disables something by default whereas %bcond_without enables something by default.

So write:

%bcond_without check

so enable checks.

 - Bump to 0.0.3

 - 
   There's a test error due to a change in *Go 1.14*, now URL are between quotes. Report it upstream and patch it locally with sed in %prep for now.

--- FAIL: Test_doaction (0.00s)
    credential_test.go:182: 
        	Error Trace:	credential_test.go:182
        	Error:      	Not equal: 
        	            	expected: "parse # #%gfdf: invalid URL escape \"%gf\""
        	            	actual  : "parse \"# #%gfdf\": invalid URL escape \"%gf\""
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-parse # #%gfdf: invalid URL escape "%gf"
        	            	+parse "# #%gfdf": invalid URL escape "%gf"
        	Test:       	Test_doaction
FAIL

sed -i 's|parse # #%%gfdf:|parse "# #%%gfdf":|' credentials/credential_test.go


 - License ok
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Comment 5 Robert-André Mauchin 🐧 2020-08-02 22:51:57 UTC
 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved.

Comment 6 Gwyn Ciesla 2020-08-03 13:13:56 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-aliyun-credentials

Comment 7 Brandon Perkins 2020-08-03 20:44:46 UTC
CLOSED. In Rawhide (f33).


Note You need to log in before you can comment on or make changes to this bug.