Bug 1812565

Summary: alertmanager/config-reloader has limits set, but shouldn't
Product: OpenShift Container Platform Reporter: Sergiusz Urbaniak <surbania>
Component: MonitoringAssignee: Paul Gier <pgier>
Status: CLOSED ERRATA QA Contact: Junqi Zhao <juzhao>
Severity: low Docs Contact:
Priority: unspecified    
Version: 4.4CC: alegrand, anpicker, erooth, kakkoyun, lcosic, mloibl, pkrupa, surbania
Target Milestone: ---   
Target Release: 4.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-07-13 17:19:39 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Sergiusz Urbaniak 2020-03-11 15:25:46 UTC
Currently we have cpu/memory limits set on config-reloader but we shouldn't:

$ kubectl -n openshift-monitoring get sts alertmanager-main -o yaml | grep -A4 config-reloader
        name: config-reloader
        resources:
          limits:
            cpu: 100m
            memory: 25Mi

We should also most likely have an e2e test asserting that no limits are being set.

Comment 1 Paul Gier 2020-03-12 14:58:20 UTC
These are the default settings from Prometheus operator.  I'm thinking we should fix this upstream and default to no limits instead of the current values.  The same limit is also present for Prometheus instances.

Comment 5 Junqi Zhao 2020-03-16 03:09:42 UTC
Tested with 4.5.0-0.nightly-2020-03-16-004817, there is not cpu/memory limits set on config-reloader
# kubectl -n openshift-monitoring get sts alertmanager-main -o yaml | grep -A4 config-reloader
        name: config-reloader
        resources: {}
        terminationMessagePath: /dev/termination-log
        terminationMessagePolicy: FallbackToLogsOnError
        volumeMounts:

Comment 7 errata-xmlrpc 2020-07-13 17:19:39 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409