Bug 1812565 - alertmanager/config-reloader has limits set, but shouldn't
Summary: alertmanager/config-reloader has limits set, but shouldn't
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Monitoring
Version: 4.4
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
: 4.5.0
Assignee: Paul Gier
QA Contact: Junqi Zhao
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-03-11 15:25 UTC by Sergiusz Urbaniak
Modified: 2020-07-13 17:20 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-07-13 17:19:39 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift cluster-monitoring-operator pull 702 0 None closed Bug 1812565: Remove cpu limits for config reloader 2020-08-17 13:47:50 UTC
Red Hat Product Errata RHBA-2020:2409 0 None None None 2020-07-13 17:20:06 UTC

Description Sergiusz Urbaniak 2020-03-11 15:25:46 UTC
Currently we have cpu/memory limits set on config-reloader but we shouldn't:

$ kubectl -n openshift-monitoring get sts alertmanager-main -o yaml | grep -A4 config-reloader
        name: config-reloader
        resources:
          limits:
            cpu: 100m
            memory: 25Mi

We should also most likely have an e2e test asserting that no limits are being set.

Comment 1 Paul Gier 2020-03-12 14:58:20 UTC
These are the default settings from Prometheus operator.  I'm thinking we should fix this upstream and default to no limits instead of the current values.  The same limit is also present for Prometheus instances.

Comment 5 Junqi Zhao 2020-03-16 03:09:42 UTC
Tested with 4.5.0-0.nightly-2020-03-16-004817, there is not cpu/memory limits set on config-reloader
# kubectl -n openshift-monitoring get sts alertmanager-main -o yaml | grep -A4 config-reloader
        name: config-reloader
        resources: {}
        terminationMessagePath: /dev/termination-log
        terminationMessagePolicy: FallbackToLogsOnError
        volumeMounts:

Comment 7 errata-xmlrpc 2020-07-13 17:19:39 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409


Note You need to log in before you can comment on or make changes to this bug.