Bug 1813258

Summary: Copy operation is very slow during a build from dockerfile with buildah-1.9.0-2.el7.x86_64 and buildah-1.11.6-8.el7_8.x86_64
Product: OpenShift Container Platform Reporter: Vedanti Jaypurkar <vjaypurk>
Component: ContainersAssignee: Nalin Dahyabhai <nalin>
Status: CLOSED ERRATA QA Contact: Weinan Liu <weinliu>
Severity: high Docs Contact:
Priority: unspecified    
Version: 4.3.zCC: adam.kaplan, aos-bugs, dornelas, dwalsh, hgomes, jhou, jokerman, nalin, schoudha, tsweeney, wzheng
Target Milestone: ---   
Target Release: 4.6.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Cause: the logic that handled COPY or ADD instructions for copying content from the build context did not efficiently filter what they were copying when a .dockerignore file was present. Consequence: COPY and ADD would be noticeably slowed by the cumulative overhead of evaluating whether each item in the source location should be copied to the destination. Fix: that logic was rewritten. Result: The presence of a .dockerignore file should no longer noticeably slow down the speed at which ADD and COPY instructions are handled during a build.
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-10-27 15:57:11 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1186913    

Comment 2 Adam Kaplan 2020-03-13 15:23:01 UTC
*** Bug 1813264 has been marked as a duplicate of this bug. ***

Comment 3 Adam Kaplan 2020-03-13 15:24:24 UTC
*** Bug 1813260 has been marked as a duplicate of this bug. ***

Comment 9 Tom Sweeney 2020-03-20 19:01:40 UTC
Probable Duplicate of https://bugzilla.redhat.com/show_bug.cgi?id=1699129

Comment 21 Nalin Dahyabhai 2020-06-18 17:56:38 UTC
We've made more progress, and the newer implementation is showing to be an improvement, but it won't be ready to be merged during the current sprint.

Comment 23 Nalin Dahyabhai 2020-07-30 21:58:27 UTC
The newer implementation is still under development, but portions of that work have been merged into the library where that logic lives.  Once it's all merged and the tests look good there, we can pull in the updated version, but I don't expect that all to be finished during this sprint.

Comment 24 Nalin Dahyabhai 2020-08-21 17:00:16 UTC
The last large piece is now up for review for inclusion in the library that we use.  Once it's merged, we'll be able to tag a release there and then pull it into the builder image.

Comment 25 Nalin Dahyabhai 2020-09-08 15:27:01 UTC
Opened https://github.com/openshift/builder/pull/172 for merging the changes.

Comment 30 errata-xmlrpc 2020-10-27 15:57:11 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.6 GA Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4196