Bug 1814281

Summary: [v2v] [RFE] UI changes for warm migration
Product: Red Hat CloudForms Management Engine Reporter: Mike Turley <mturley>
Component: V2VAssignee: Mike Turley <mturley>
Status: CLOSED WONTFIX QA Contact: Nandini Chandra <nachandr>
Severity: medium Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: high    
Version: unspecifiedCC: akarol, bthurber, fdupont, simaishi, sshveta
Target Milestone: GA   
Target Release: 5.11.7   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-05-13 16:46:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: V2V Target Upstream Version:
Embargoed:

Description Mike Turley 2020-03-17 14:47:16 UTC
UI changes will need to be backported for 5.11.5 to support the warm migration feature.

Comment 2 Mike Turley 2020-03-17 14:52:49 UTC
*** Bug 1814284 has been marked as a duplicate of this bug. ***

Comment 3 Mike Turley 2020-03-20 17:36:40 UTC
UI PRs to be included here:

* https://github.com/ManageIQ/manageiq-v2v/pull/1031 (List view to table conversion)
* https://github.com/ManageIQ/manageiq-v2v/pull/1042 (Plan wizard changes)
* https://github.com/ManageIQ/manageiq-v2v/pull/1048 (Plans in progress layout conversion)
* https://github.com/ManageIQ/manageiq-v2v/pull/1057 (Plan details layout conversion w/ expandable rows)
* https://github.com/ManageIQ/manageiq-v2v/pull/1070 (Schedule modal changes)
* https://github.com/ManageIQ/manageiq-v2v/pull/1075 (Warning popover in plan wizard)
* https://github.com/ManageIQ/manageiq-v2v/pull/1082 (VDDK conversion host validation)
* https://github.com/ManageIQ/manageiq-v2v/pull/1091 (RHV target validation)
* https://github.com/ManageIQ/manageiq-v2v/pull/1095 (Cutover unschedule feature)
* https://github.com/ManageIQ/manageiq-v2v/pull/1119 (Remaining API integration)

Comment 4 Mike Turley 2020-03-20 17:41:19 UTC
You can also see this list of PRs by filtering on the labels "warm migration" and "ivanchuk/yes" in the list of closed PRs on manageiq-v2v. https://github.com/ManageIQ/manageiq-v2v/pulls?q=is%3Apr+is%3Aclosed+label%3A%22warm+migration%22+label%3Aivanchuk%2Fyes

Satoe, I know some of these will have significant merge conflicts with ivanchuk, I'm preparing some backport PRs now.

Comment 5 Mike Turley 2020-03-20 18:35:50 UTC
Whoops, the list of PRs above was in the order on GitHub (when the PRs were opened) not the order they were merged. Here they are in merge order:

2019-09-19: https://github.com/ManageIQ/manageiq-v2v/pull/1031 (List view to table conversion)
2019-10-10: https://github.com/ManageIQ/manageiq-v2v/pull/1048 (Plans in progress layout conversion)
2019-10-22: https://github.com/ManageIQ/manageiq-v2v/pull/1042 (Plan wizard changes)
2019-11-05: https://github.com/ManageIQ/manageiq-v2v/pull/1057 (Plan details layout conversion w/ expandable rows)
2019-12-06: https://github.com/ManageIQ/manageiq-v2v/pull/1075 (Warning popover in plan wizard)
2020-01-08: https://github.com/ManageIQ/manageiq-v2v/pull/1082 (VDDK conversion host validation)
2020-01-20: https://github.com/ManageIQ/manageiq-v2v/pull/1091 (RHV target validation)
2020-01-23: https://github.com/ManageIQ/manageiq-v2v/pull/1070 (Schedule modal changes)
2020-02-04: https://github.com/ManageIQ/manageiq-v2v/pull/1095 (Cutover unschedule feature)
2020-03-20: https://github.com/ManageIQ/manageiq-v2v/pull/1119 (Remaining API integration)

Comment 6 Mike Turley 2020-03-23 20:09:41 UTC
I missed a PR in my list above, merged 2020-02-17: https://github.com/ManageIQ/manageiq-v2v/pull/1104 (Add tests for warm migration modal changes)

Comment 7 Mike Turley 2020-03-23 20:20:18 UTC
Satoe, I cherry-picked these PRs to ivanchuk locally and made some ivanchuk PRs for the ones with conflicts:

* PR#1031 should backport without conflicts
* PR#1048 will have conflicts, backport PR here: https://github.com/ManageIQ/manageiq-v2v/pull/1120
* PR#1042 should backport without conflicts
* PR#1057 should backport without conflicts
* PR#1075 will have conflicts, backport PR here: https://github.com/ManageIQ/manageiq-v2v/pull/1121
* PR#1082 should backport without conflicts
* PR#1091 should backport without conflicts
* PR#1070 should backport without conflicts
* PR#1095 should backport without conflicts
* PR#1104 should backport without conflicts (forgot in my last list)
* PR#1119 should backport without conflicts

As long as those are all included in that order, we should be all set!

Comment 8 Nandini Chandra 2020-04-06 22:27:26 UTC
Verified in  master.20200403002716_63b3608c8d

Comment 9 CFME Bot 2020-05-01 23:31:27 UTC
New commit detected on ManageIQ/manageiq-v2v/jansa:

https://github.com/ManageIQ/manageiq-v2v/commit/cbd0513f6a53ff64f7988d80bed4dc9ed3fe41e1
commit cbd0513f6a53ff64f7988d80bed4dc9ed3fe41e1
Author:     Milan Zázrivec <mzazrivec>
AuthorDate: Fri Mar 20 16:31:05 2020 +0000
Commit:     Milan Zázrivec <mzazrivec>
CommitDate: Fri Mar 20 16:31:05 2020 +0000

    Merge pull request #1119 from mturley/warm-migration-end-to-end

    Remaining warm migration UI changes (Plans and Plan Details views)

    (cherry picked from commit 7cccd541b075ae910ca19acd03c6438beb204ed6)

    https://bugzilla.redhat.com/show_bug.cgi?id=1814281

 app/javascript/react/screens/App/Overview/OverviewActions.js | 24 +-
 app/javascript/react/screens/App/Overview/components/Migrations/CutoverTimeInfoItem.js | 9 +-
 app/javascript/react/screens/App/Overview/components/Migrations/InProgressRow.js | 2 +-
 app/javascript/react/screens/App/Overview/components/Migrations/MigrationInProgressListItem.js | 243 +-
 app/javascript/react/screens/App/Overview/components/Migrations/Migrations.scss | 28 +-
 app/javascript/react/screens/App/Overview/components/Migrations/MigrationsCompletedList.js | 32 +-
 app/javascript/react/screens/App/Overview/components/Migrations/MigrationsNotStartedList.js | 6 +-
 app/javascript/react/screens/App/Overview/components/Migrations/ScheduledTimeInfoItem.js | 3 +-
 app/javascript/react/screens/App/Overview/components/Migrations/__test__/CutoverTimeInfoItem.test.js | 16 +-
 app/javascript/react/screens/App/Overview/components/Migrations/__test__/__snapshots__/MigrationInProgressListItem.test.js.snap | 440 +-
 app/javascript/react/screens/App/Overview/components/Migrations/helpers/getPlanScheduleInfo.js | 11 +-
 app/javascript/react/screens/App/Overview/components/ScheduleMigrationModal/ScheduleMigrationModal.js | 13 +-
 app/javascript/react/screens/App/Overview/overview.transformationPlans.fixtures.js | 6 +-
 app/javascript/react/screens/App/Plan/Plan.scss | 87 +-
 app/javascript/react/screens/App/Plan/PlanConstants.js | 2 +-
 app/javascript/react/screens/App/Plan/components/PlanRequestDetailList/PlanRequestDetailList.js | 277 +-
 app/javascript/react/screens/App/Plan/components/PlanRequestDetailList/PlanRequestDetailListItem.js | 335 +
 app/javascript/react/screens/App/Plan/helpers.js | 3 +
 app/javascript/react/screens/App/common/ListViewTable/ListViewTableRow.js | 30 +-
 app/javascript/react/screens/App/common/warmMigrationConstants.js | 1 +
 app/javascript/react/screens/App/common/warmMigrationHelpers.js | 74 +
 21 files changed, 837 insertions(+), 805 deletions(-)

Comment 10 Fabien Dupont 2020-05-13 16:46:58 UTC
Warm migration and UCI will finally not be implemented in CloudForms.
Closing as WONTFIX.

Comment 11 Mike Turley 2020-05-14 17:44:30 UTC
I'm excluding https://github.com/ManageIQ/manageiq-v2v/pull/1031 from this because it is useful for cold migration and difficult to revert. New BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1835911