Bug 1814618

Summary: openshift-apiserver-operator spams update events
Product: OpenShift Container Platform Reporter: Standa Laznicka <slaznick>
Component: openshift-apiserverAssignee: Stefan Schimanski <sttts>
Status: CLOSED ERRATA QA Contact: Ke Wang <kewang>
Severity: urgent Docs Contact:
Priority: urgent    
Version: 4.4CC: aos-bugs, kewang, mfojtik, sanchezl
Target Milestone: ---   
Target Release: 4.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of:
: 1814621 (view as bug list) Environment:
Last Closed: 2020-07-13 17:22:24 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1813919, 1814621    

Description Standa Laznicka 2020-03-18 11:52:30 UTC
Description of problem:
wrong comparison of values of different types causes update event to be announced even if the values did not change

Logs:
...
I0316 13:48:15.338406       1 event.go:281] Event(v1.ObjectReference{Kind:"Deployment", Namespace:"openshift-apiserver-operator", Name:"openshift-apiserver-operator", UID:"10e44167-910d-40b9-b62a-6ae927ecb165", APIVersion:"apps/v1", ResourceVersion:"", FieldPath:""}): type: 'Normal' reason: 'ObserveStorageUpdated' Updated storage urls to https://10.0.130.223:2379,https://10.0.134.12:2379,https://10.0.144.238:2379
I0316 13:48:16.338521       1 event.go:281] Event(v1.ObjectReference{Kind:"Deployment", Namespace:"openshift-apiserver-operator", Name:"openshift-apiserver-operator", UID:"10e44167-910d-40b9-b62a-6ae927ecb165", APIVersion:"apps/v1", ResourceVersion:"", FieldPath:""}): type: 'Normal' reason: 'ObserveStorageUpdated' Updated storage urls to https://10.0.130.223:2379,https://10.0.134.12:2379,https://10.0.144.238:2379
I0316 13:48:17.338679       1 event.go:281] Event(v1.ObjectReference{Kind:"Deployment", Namespace:"openshift-apiserver-operator", Name:"openshift-apiserver-operator", UID:"10e44167-910d-40b9-b62a-6ae927ecb165", APIVersion:"apps/v1", ResourceVersion:"", FieldPath:""}): type: 'Normal' reason: 'ObserveStorageUpdated' Updated storage urls to https://10.0.130.223:2379,https://10.0.134.12:2379,https://10.0.144.238:2379
I0316 13:48:18.338827       1 event.go:281] Event(v1.ObjectReference{Kind:"Deployment", Namespace:"openshift-apiserver-operator", Name:"openshift-apiserver-operator", UID:"10e44167-910d-40b9-b62a-6ae927ecb165", APIVersion:"apps/v1", ResourceVersion:"", FieldPath:""}): type: 'Normal' reason: 'ObserveStorageUpdated' Updated storage urls to https://10.0.130.223:2379,https://10.0.134.12:2379,https://10.0.144.238:2379
I0316 13:48:19.338948       1 event.go:281] Event(v1.ObjectReference{Kind:"Deployment", Namespace:"openshift-apiserver-operator", Name:"openshift-apiserver-operator", UID:"10e44167-910d-40b9-b62a-6ae927ecb165", APIVersion:"apps/v1", ResourceVersion:"", FieldPath:""}): type: 'Normal' reason: 'ObserveStorageUpdated' Updated storage urls to https://10.0.130.223:2379,https://10.0.134.12:2379,https://10.0.144.238:2379
I0316 13:48:20.338980       1 event.go:281] Event(v1.ObjectReference{Kind:"Deployment", Namespace:"openshift-apiserver-operator", Name:"openshift-apiserver-operator", UID:"10e44167-910d-40b9-b62a-6ae927ecb165", APIVersion:"apps/v1", ResourceVersion:"", FieldPath:""}): type: 'Normal' reason: 'ObserveStorageUpdated' Updated storage urls to https://10.0.130.223:2379,https://10.0.134.12:2379,https://10.0.144.238:2379
I0316 13:48:21.339221       1 event.go:281] Event(v1.ObjectReference{Kind:"Deployment", Namespace:"openshift-apiserver-operator", Name:"openshift-apiserver-operator", UID:"10e44167-910d-40b9-b62a-6ae927ecb165", APIVersion:"apps/v1", ResourceVersion:"", FieldPath:""}): type: 'Normal' reason: 'ObserveStorageUpdated' Updated storage urls to https://10.0.130.223:2379,https://10.0.134.12:2379,https://10.0.144.238:2379
I0316 13:48:22.339413       1 event.go:281] Event(v1.ObjectReference{Kind:"Deployment", Namespace:"openshift-apiserver-operator", Name:"openshift-apiserver-operator", UID:"10e44167-910d-40b9-b62a-6ae927ecb165", APIVersion:"apps/v1", ResourceVersion:"", FieldPath:""}): type: 'Normal' reason: 'ObserveStorageUpdated' Updated storage urls to https://10.0.130.223:2379,https://10.0.134.12:2379,https://10.0.144.238:2379
I0316 13:48:23.339501       1 event.go:281] Event(v1.ObjectReference{Kind:"Deployment", Namespace:"openshift-apiserver-operator", Name:"openshift-apiserver-operator", UID:"10e44167-910d-40b9-b62a-6ae927ecb165", APIVersion:"apps/v1", ResourceVersion:"", FieldPath:""}): type: 'Normal' reason: 'ObserveStorageUpdated' Updated storage urls to https://10.0.130.223:2379,https://10.0.134.12:2379,https://10.0.144.238:2379
I0316 13:48:24.339619       1 event.go:281] Event(v1.ObjectReference{Kind:"Deployment", Namespace:"openshift-apiserver-operator", Name:"openshift-apiserver-operator", UID:"10e44167-910d-40b9-b62a-6ae927ecb165", APIVersion:"apps/v1", ResourceVersion:"", FieldPath:""}): type: 'Normal' reason: 'ObserveStorageUpdated' Updated storage urls to https://10.0.130.223:2379,https://10.0.134.12:2379,https://10.0.144.238:2379
I0316 13:48:25.339752       1 event.go:281] Event(v1.ObjectReference{Kind:"Deployment", Namespace:"openshift-apiserver-operator", Name:"openshift-apiserver-operator", UID:"10e44167-910d-40b9-b62a-6ae927ecb165", APIVersion:"apps/v1", ResourceVersion:"", FieldPath:""}): type: 'Normal' reason: 'ObserveStorageUpdated' Updated storage urls to https://10.0.130.223:2379,https://10.0.134.12:2379,https://10.0.144.238:2379
...

Comment 1 Standa Laznicka 2020-03-18 12:49:06 UTC
Please know that this was backported to 4.4 in https://github.com/openshift/cluster-openshift-apiserver-operator/pull/339.

To test, you can just run `oc logs -n openshift-apiserver-operator deployment/openshift-apiserver-operator` and see that they do not contain the log mentioned above.

Comment 5 Standa Laznicka 2020-03-19 15:02:13 UTC
*** Bug 1814692 has been marked as a duplicate of this bug. ***

Comment 8 Ke Wang 2020-04-02 05:36:32 UTC
Verified with the following OCP 4.5 build, 

$ oc get clusterversion
NAME      VERSION                             AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.5.0-0.nightly-2020-04-01-235324   True        False         16m     Cluster version is 4.5.0-0.nightly-2020-04-01-235324

Verification steps,
$ oc logs -n openshift-apiserver-operator deployment/openshift-apiserver-operator | grep -i 'ObserveStorageUpdated'

Nothing found for above mentioned log.

Comment 10 errata-xmlrpc 2020-07-13 17:22:24 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409