Bug 1818172

Description of problem:
When using OpenStack provider and the approval is required to fulfil the request (for example when more than one VM is requried), the email about pending request is sent.

The email address of current user (In access control in CFME configuration) is used in the subject of the email about request pending status, no matter what is set in the request dialog. This is in the evm.log:

[----] I, [2020-03-27T17:28:33.931559 #7241:2ad49864e5b4]  INFO -- : MIQ(GenericMailer#prepare_generic_email) options: {:to=>"evmadmin", :from=>"evmadmin", :cc=>nil, :bcc=>nil, :subject=>"Request ID 10 - Virtual Machine Request from changed-email-cloud-vm Pending Approval.", :content_type=>nil, :body=>"Approver, <br/><br/>A Virtual Machine Request received from changed-email-cloud-vm is Pending.<br/><br/>Request was not auto-approved for the following reasons: (Requested VMs 2 limit is 1) .<br/><br/>Approvers notes : <br/><br/>For more information you can go to : <a href=https://XXX.redhat.com/miq_request/show/10>https://XXX.rdu2.redhat.com/miq_request/show/10</a><br/><br/> Thank you,<br/> Virtualization Infrastructure Team", :sent_on=>2020-03-27 17:28:33 -0400, :attachment=>[]}


Indeed, on our SMTP server I can see messages like:
Request ID 1 - Instance Request from Pending Approval.


When Infra Provider (I tested RHEV), the email from the provisioning request seems to be used for the email subject. I can see this in evm.log:

[----] E, [2020-03-27T17:28:34.509724 #7241:2ad49864e5b4] ERROR -- : MIQ(GenericMailer.deliver) method: automation_notification options: {:to=>"evmadmin", :from=>"evmadmin", :cc=>nil, :bcc=>nil, :subject=>"Request ID 10 - Virtual Machine Request from changed-email-cloud-vm Pending Approval.", :content_type=>nil, :body=>"Approver, <br/><br/>A Virtual Machine Request received from changed-email-cloud-vm is Pending.<br/><br/>Request was not auto-approved for the following reasons: (Requested VMs 2 limit is 1) .<br/><br/>Approvers notes : <br/><br/>For more information you can go to : <a href=https://XXX.rdu2.redhat.com/miq_request/show/10>https://XXX.rdu2.redhat.com/miq_request/show/10</a><br/><br/> Thank you,<br/> Virtualization Infrastructure Team", :sent_on=>2020-03-27 17:28:33 -0400, :attachment=>[]} delivery-error 450 4.1.8 <evmadmin>: Sender address rejected: Malformed DNS server reply


Version-Release number of selected component (if applicable):
5.11.4.2


How reproducible:
always


Steps to Reproduce:
0. Enable Notifier role.
1. Configure SMTP on CFME to working smtp server as it seems to be required for a log message to appear.
2. Verify the configuration is right
3. Verify the current user's email address is empty in the Access control in Configuration.
4. Create request for 2 VM on OpenStack provider (or any other that doesn't get auto-approved).
Crate similar request wiht RHEV provider.

fill all the items as you need, remember what you have set as  Request Information email

Actual results:
 * Email about pending request with missing noun in subject sent for Cloud provisioning request
 * Email about pending request with info filled on provisioning dialog in subject sent for RHEV provisioning request



Expected results:
Email sent and content uses the email set in the provisioning dialog no matter which provider is used.


Additional info:
I found no way to set the email recipient. I am sure it is hidden somewhere in Automate. I feel like this feature of sending emails probably has never been really in use by customer as it is not working well and it seems too unclear how to configure it.

Note that there was this bug about the same, but probably fixed for the Infra providers only:
https://bugzilla.redhat.com/show_bug.cgi?id=1672690