Backported to Hammer branch: commit d1296eb8fd2a6412d17629b93273da2643a690e7 Author: tina <tina.fitzgerald2> Date: Tue Dec 18 13:16:23 2018 -0500 Merge pull request #484 from rh-dluong/fix-automate-email-approverrequest Bug 1628240 - Fix missing word in provisioning mail's subject and body (cherry picked from commit ec90ad2a1c99c3c53a943fca8aabeb2e5e35c77d) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1672690
New commit detected on ManageIQ/manageiq-content/hammer: https://github.com/ManageIQ/manageiq-content/commit/d1296eb8fd2a6412d17629b93273da2643a690e7 commit d1296eb8fd2a6412d17629b93273da2643a690e7 Author: tina <tina.fitzgerald2> AuthorDate: Tue Dec 18 13:16:23 2018 -0500 Commit: tina <tina.fitzgerald2> CommitDate: Tue Dec 18 13:16:23 2018 -0500 Merge pull request #484 from rh-dluong/fix-automate-email-approverrequest Bug 1628240 - Fix missing word in provisioning mail's subject and body (cherry picked from commit ec90ad2a1c99c3c53a943fca8aabeb2e5e35c77d) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1672690 content/automate/ManageIQ/System/Notification/Email.class/infrastructuremiqprovisionrequestapproverapproved.yaml | 4 +- content/automate/ManageIQ/System/Notification/Email.class/infrastructuremiqprovisionrequestapproverdenied.yaml | 4 +- content/automate/ManageIQ/System/Notification/Email.class/infrastructuremiqprovisionrequestapproverpending.yaml | 4 +- 3 files changed, 6 insertions(+), 6 deletions(-)
I can see this in the cfme evm.log: [----] I, [2019-02-13T05:18:35.621003 #15083:10c6f60] INFO -- : MIQ(GenericMailer#prepare_generic_email) options: {:to=>"evmadmin", :from=>"evmadmin", :subject=>"Request ID 1 - Virtual Machine Request from vm_provision Pending Approval.", :content_type=>nil, :body=>"Approver, <br/><br/>A Virtual Machine Request received from vm_provision is Pending.<br/><br/>Request was not auto-approved for the following reasons: (Requested VMs 2 limit is 1) .<br/><br/>Approvers notes : <br/><br/>For more information you can go to : <a href=https://dhcp-8-196-100.cfme2.lab.eng.rdu2.redhat.com/miq_request/show/1>https://dhcp-8-196-100.cfme2.lab.eng.rdu2.redhat.com/miq_request/show/1</a><br/><br/> Thank you,<br/> Virtualization Infrastructure Team", :sent_on=>2019-02-13 05:18:35 -0500} and I see this email on our special python mail server: {u'text': u'<p>\nApprover, <br/><br/>A Virtual Machine Request received from vm_provision is Pending.<br/><br/>Request was not auto-approved for the following reasons: (Requested VMs 2 limit is 1) .<br/><br/>Approvers notes : <br/><br/>For more information you can go to : <a href=https://dhcp-8-196-100.cfme2.lab.eng.rdu2.redhat.com/miq_request/show/1>https://dhcp-8-196-100.cfme2.lab.eng.rdu2.redhat.com/miq_request/show/1</a><br/><br/> Thank you,<br/> Virtualization Infrastructure Team\n</p>', u'subject': u'Request ID 1 - Virtual Machine Request from vm_provision\n Pending Approval.', u'to_address': u'evmadmin', u'from_address': u'evmadmin', u'time': u'2019-02-13 10:18:37'} but I cannot receive it using my redhat gmail. I think it may be caused by \n in the subject.
I cannot make CFME send the the approval request to my RedHat account, but in our tests it works fine.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2019:0453
New commit detected on ManageIQ/manageiq-content/master: https://github.com/ManageIQ/manageiq-content/commit/031023c8847ae0ab72a558082bba7a5ee6eb9528 commit 031023c8847ae0ab72a558082bba7a5ee6eb9528 Author: William Fitzgerald <wfitzger> AuthorDate: Wed Apr 8 13:58:43 2020 +0000 Commit: William Fitzgerald <wfitzger> CommitDate: Wed Apr 8 13:58:43 2020 +0000 Was looking for Owner email in the wrong place. Changed by setting the email to ${/#miq_request.get_option(:owner_email)} instead of ${/#miq_request.requester.email}. in three email yams files. The Infra was changed in previous PR #484 Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1672690 @miq-bot add_label bug @miq-bot assign @tinaafitz content/automate/ManageIQ/System/Notification/Email.class/cloudmiqprovisionrequestapproverapproved.yaml | 6 +- content/automate/ManageIQ/System/Notification/Email.class/cloudmiqprovisionrequestapproverdenied.yaml | 4 +- content/automate/ManageIQ/System/Notification/Email.class/cloudmiqprovisionrequestapproverpending.yaml | 4 +- 3 files changed, 7 insertions(+), 7 deletions(-)