Bug 181824
| Summary: | Review Request: gstreamer08 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Brian Pepple <bdpepple> | ||||||
| Component: | Package Review | Assignee: | Ignacio Vazquez-Abrams <ivazqueznet> | ||||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | bugs.michael | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2006-03-05 15:30:50 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 163779, 176288, 180164, 183694 | ||||||||
| Attachments: |
|
||||||||
|
Description
Brian Pepple
2006-02-16 21:27:46 UTC
- Use --disable-static instead of erasing .a files - Use --disable-rpath - Period at the end of Summary of -devel Spec Url: http://piedmont.homelinux.org/fedora/gstreamer/gstreamer08.spec SRPM Url: http://piedmont.homelinux.org/fedora/gstreamer/gstreamer08-0.8.12-2.src.rpm Description: * Thu Feb 23 2006 Brian Pepple <bdpepple> - 0.8.12-2 - Use --disable-rpath & --disable-static. - Drop period in devel summary. Created attachment 125163 [details]
gstreamer08 build log
Interesting. That doesn't seem to have gotten rid of the rpaths.
E: gstreamer08 binary-or-shlib-defines-rpath
/usr/lib/gstreamer-0.8/libgstgetbits.so
['/var/tmp/gstreamer08-0.8.12-2-root-mockbuild/usr/lib']
Hmmm, probably something messed up in it's configure script. Unfortunately, I'm going to be fairly busy the next couple of weeks, and probably won't have time to track down the problem. As per IRC we'll ignore the rpath issue for now, so APPROVED. The rpath issues will be caught by check-rpaths in the build system and will make the build fail, provided that it occurs. Further, since it is a path in /var/tmp, it is a blocker. (In reply to comment #6) > The rpath issues will be caught by check-rpaths in the build system > and will make the build fail, provided that it occurs. Does the buildsys really check those things currently? I don't think so -- I've seen some packages in Extras that had hardcoded rpaths. (In reply to comment #7) > Does the buildsys really check those things currently? I don't think so -- I've > seen some packages in Extras that had hardcoded rpaths. I think your right, but off the top of my head I can't think of any of the packages. Okay, guys, are we stuck again? Let's get this moving, we're running out of time. AFAICS the rpath are the only remaining big problem? If yes my vote is: Import it and builds it. If it really fails to build look closer. Correnty me if I'm wrong or overlooked something important. (In reply to comment #9) > Correnty me if I'm wrong or overlooked something important. See for example comment 6. rpath pointing to /var/tmp/... is definitely a blocker-worthy security issue. Okay, seems I must look into this myself... Test were done on a i386 machine with rawhide from 20060303 > [...] >checking for bison... no >configure: error: Could not find bison "BuildRequire: bison" ? >checking for flex... no >configure: error: Could not find flex "BuildRequire: flex" ? /me wonders if there are other BR missing. >$ grep rpath .rpmmacros >%__arch_install_post /usr/lib/rpm/check-rpaths /usr/lib/rpm/check-buildroot Build fine. >$ rpmlint /home/thl/rpmbuild/RPMS/i386/gstreamer08-0.8.12-2.i386.rpm >/home/thl/rpmbuild/RPMS/i386/gstreamer08-devel-0.8.12-2.i386.rpm >W: gstreamer08 non-standard-dir-in-usr libexec >E: gstreamer08-devel zero-length >/usr/share/doc/gstreamer08-devel-0.8.12/html/base.css No rpath. /me confused now -- missing BRs that nobody found before, but the rpath problem didn't show up. Or did I do something totally wrong? Thorsten, would you please calm down a bit and not push everyone like that? The rpaths show up when building the package as root. Can confirm this here and going to look into it later. "BR libtool automake bison flex" are needed when not building with mock. (In reply to comment #12) > Thorsten, would you please calm down a bit and not push everyone like > that? Sorry, will try. But I think the gst08 issue is an/the most important one that we really should fix before FC5 goes final. And there is not much time left. That's why I'm trying to push this issue a bit. > The rpaths show up when building the package as root. Can confirm this > here and going to look into it later. Many thx. Created attachment 125640 [details]
spec patch to fix rpath issues
Confirmed that the spec file patch fixes the rpath issues. Thanks, Michael, for correcting this. Spec Url: http://piedmont.homelinux.org/fedora/gstreamer/gstreamer08.spec SRPM Url: http://piedmont.homelinux.org/fedora/gstreamer/gstreamer08-0.8.12-3.src.rpm * Sat Mar 4 2006 Brian Pepple <bdpepple> - 0.8.12-3 - Fix docdir installation (Thanks to Michael Schwendt). The changes in the doc installation are just a side-effect and necessity of installing with DESTDIR= instead of %makeinstall. ;) The %makeinstall macro breaks everytime any of the paths it modifies (it prepends %buildroot!) make it into files which are packaged. Are there any other blockers on this package? No immediate blockers left. Unless a package, which requires this, will turn up build-time problems. %changelog of 0.8.12-3 doesn't match comment 14, though. Package built |