Bug 183694 - Review Request: gstreamer08-plugins
Summary: Review Request: gstreamer08-plugins
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Michael Schwendt
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On: 181824
Blocks: FE-ACCEPT 180164
TreeView+ depends on / blocked
 
Reported: 2006-03-02 21:06 UTC by Brian Pepple
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-08-29 10:07:34 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
spec patch (3.41 KB, patch)
2006-03-04 22:43 UTC, Michael Schwendt
no flags Details | Diff

Description Brian Pepple 2006-03-02 21:06:15 UTC
Spec Name or Url: http://piedmont.homelinux.org/fedora/gstreamer/gstreamer08-plugins.spec
SRPM Name or Url: http://piedmont.homelinux.org/fedora/gstreamer/gstreamer08-plugins-0.8.12-1.src.rpm
Description: GStreamer Streaming media framework plug-ins

Comment 1 Michael Schwendt 2006-03-04 14:59:40 UTC
Quick observation while trying to get it to build:

BR gstreamer08-devel NOT gstreamer-devel
BR libGL-devel NOT mesa-libGL-devel



Comment 2 Michael Schwendt 2006-03-04 17:03:07 UTC
Hmmm, osssink works, alsasink fails:

$ gst-launch-0.8 filesrc location=test.wav ! wavparse ! alsasink
RUNNING pipeline ...
ERROR: from element /pipeline0/alsasink0: Internal GStreamer error: state change
failed.  File a bug.

$ gst-launch-0.8 filesrc location=test.ogg ! oggdemux ! vorbisdec ! audioconvert
! alsasink
RUNNING pipeline ...
ERROR: from element /pipeline0/vorbisdec0: Internal GStreamer error: pad
problem.  File a bug.
Additional debug info:
gstpad.c(2562): gst_pad_set_explicit_caps: /pipeline0/vorbisdec0:
failed to negotiate (try_set_caps with "audio/x-raw-float, rate=(int)11025,
channels=(int)1, endianness=(int)1234, width=(int)32, buffer-frames=(int)0"
returned REFUSED)


Comment 3 Brian Pepple 2006-03-04 19:04:32 UTC
(In reply to comment #2)
Was this working in prior versions in Rawhide?  This looks like it's been an
issue for awhile: http://bugzilla.gnome.org/show_bug.cgi?id=308045

If I have any free time later today, I'll give it a closer look.


Comment 4 Michael Schwendt 2006-03-04 22:42:25 UTC
Both work with gst-launch-0.10, and they are examples from the manual page.
I recall there have been similar/same problems with GStreamer/ALSA before.

Suggest an alternative test on how to verify whether this GStreamer works.
What applications need this version of GStreamer?

This different one works:

gst-launch-0.8 filesrc location=test.wav ! typefind ! spider ! audioconvert !
audioscale ! volume ! alsasink

gst-launch-0.8 filesrc location=test.wav ! typefind ! spider ! audioconvert !
audioscale ! volume ! alsasink device=hw:0

$ gconftool-2 -g /system/gstreamer/0.8/default/audiosink
alsasink

[...]

Anyway, I have a few issues with this package:

* Source tarball has not been stripped off of code with legal issues.
  The "removed-sources.txt" for 0.8.11 is included, but the source
  tarball has been upgraded to 0.8.12. [BLOCKER]

* GConf2 scriptlets are incomplete.

* Requiring /usr/bin/gconftool-2, but running "gconftool-2" is unclean.
  Require exactly what you run. If you run "gconftool-2" from $PATH,
  don't require an absolute path.

* Inter-package deps are wrong: references to gstreamer-devel
  [BLOCKER]

* Explicit "Requires: cdparanoia-libs >= alpha9.7" and
  "Requires: libmusicbrainz >= 2.1.1" are not needed, since the
  automatic soname dependencies are present and the minimum versions
  of those packages are available in FC5.

* GStreamer libdir is included in main package already.

* The two executables in this package are Perl scripts and create an
  ugly dependency on Perl. Not a blocker, but not nice. Considering that
  this is just sort of a compatibility package, do we need them?


Comment 5 Michael Schwendt 2006-03-04 22:43:23 UTC
Created attachment 125648 [details]
spec patch

Comment 6 Brian Pepple 2006-03-05 21:44:44 UTC
Spec Url: http://piedmont.homelinux.org/fedora/gstreamer/gstreamer08-plugins.spec
SRPM Url:
http://piedmont.homelinux.org/fedora/gstreamer/gstreamer08-plugins-0.8.12-2.src.rpm

* Sun Mar  5 2006 Brian Pepple <bdpepple> - 0.8.12-2
- Add patch-tarball.sh back.
- Strip source tarball of code w/ legal issues.
- Remove req. for cdparanoia-libs & libmusicbrainz.
- Fix references to gstreamer-devel.
- Fix GConf2 scriptlets.

Comment 7 Brian Pepple 2006-03-05 21:57:16 UTC
(In reply to comment #4)
> 
> Suggest an alternative test on how to verify whether this GStreamer works.
> What applications need this version of GStreamer?
> 

Gnome-Baker.  I had no problems burning an audio cd with this gstreamer-plugin
(tested w/ ogg & flac).  


Comment 8 Michael Schwendt 2006-03-06 18:38:45 UTC
0.8.12-2 approved. I deliberately ignore the plugins which are not built,
as I believe any additional plugins not found in Core should make it into
an -extras plugins package.

Comment 9 Brian Pepple 2006-03-06 20:48:28 UTC
Package built.


Note You need to log in before you can comment on or make changes to this bug.