Bug 1819998

Summary: [UPSTREAM] Unable to cancel migration from CFME
Product: Red Hat CloudForms Management Engine Reporter: Nandini Chandra <nachandr>
Component: V2VAssignee: Fabien Dupont <fdupont>
Status: CLOSED ERRATA QA Contact: Nandini Chandra <nachandr>
Severity: high Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: high    
Version: 5.11.4CC: bthurber, fdupont, mnadeem, simaishi, tuado
Target Milestone: GAKeywords: ZStream
Target Release: 5.11.6Flags: pm-rhel: cfme-5.11.z+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.11.6.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-06-10 13:39:10 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: V2V Target Upstream Version:
Embargoed:
Attachments:
Description Flags
screen shot of infini spinner on a migration plan none

Description Nandini Chandra 2020-04-02 03:29:09 UTC
Description of problem:
-----------------------
I'm unable to cancel migration through CFME UI when a migration doesn't progress. According to the logs,the migration failed because of a failed preflight check and the spinner keeps spinning on the plan. 
At this point, I'm unable to cancel the migration.

Version-Release number of selected component (if applicable):
------------------------------------------------------------
master.20200401002122_8bd930cd58


How reproducible:
-----------------
Always


Steps to Reproduce:
------------------
1.Initiate a migration
2.Navigate to the Migration->Migration Plans page.
3.Click on the 'Migration in Progress' tab. Select a plan and hit 'Cancel Migration'.


Actual results:
---------------
It is not possible to cancel migration from CFME UI when migration doesn't progress.


Expected results:
-----------------
It should be possible to cancel migration from CFME UI.

Comment 2 Nandini Chandra 2020-04-02 03:54:20 UTC
Created attachment 1675593 [details]
screen shot of infini spinner on a migration plan

Comment 3 Fabien Dupont 2020-04-02 08:37:37 UTC
Here, the problem is not that the task cannot be cancelled. It is indeed cancelled, but the workflow doesn't exit.
This is still a bug as the migration task should exit in error. This is fixed by: https://github.com/ManageIQ/manageiq-content/pull/651.

Comment 4 Fabien Dupont 2020-04-02 15:33:13 UTC
*** Bug 1820246 has been marked as a duplicate of this bug. ***

Comment 5 CFME Bot 2020-04-07 19:15:41 UTC
New commit detected on ManageIQ/manageiq-content/jansa:

https://github.com/ManageIQ/manageiq-content/commit/1b00d78cdf7fe953b8c4dea7605aef5141d11a78
commit 1b00d78cdf7fe953b8c4dea7605aef5141d11a78
Author:     tina <tfitzger>
AuthorDate: Mon Apr  6 14:52:50 2020 +0000
Commit:     tina <tfitzger>
CommitDate: Mon Apr  6 14:52:50 2020 +0000

    Merge pull request #651 from fdupont-redhat/bz_1819998

    Fix unhandled task failure during preflight check

    (cherry picked from commit b46ada57ad122a1e2ba92717f5b436282d027959)

    https://bugzilla.redhat.com/show_bug.cgi?id=1819998

 content/automate/ManageIQ/Transformation/Common.class/__methods__/waitforhandover.rb | 2 +-
 spec/content/automate/ManageIQ/Transformation/Common.class/__methods__/waitforhandover_spec.rb | 7 +
 2 files changed, 8 insertions(+), 1 deletion(-)

Comment 6 CFME Bot 2020-04-07 19:15:42 UTC
New commit detected on ManageIQ/manageiq-content/ivanchuk:

https://github.com/ManageIQ/manageiq-content/commit/6925d84a361a940d0bec0d3c8a7ef1a31b40305c
commit 6925d84a361a940d0bec0d3c8a7ef1a31b40305c
Author:     tina <tfitzger>
AuthorDate: Mon Apr  6 14:52:50 2020 +0000
Commit:     tina <tfitzger>
CommitDate: Mon Apr  6 14:52:50 2020 +0000

    Merge pull request #651 from fdupont-redhat/bz_1819998

    Fix unhandled task failure during preflight check

    (cherry picked from commit b46ada57ad122a1e2ba92717f5b436282d027959)

    https://bugzilla.redhat.com/show_bug.cgi?id=1819998

 content/automate/ManageIQ/Transformation/Common.class/__methods__/waitforhandover.rb | 2 +-
 spec/content/automate/ManageIQ/Transformation/Common.class/__methods__/waitforhandover_spec.rb | 7 +
 2 files changed, 8 insertions(+), 1 deletion(-)

Comment 8 Fabien Dupont 2020-04-23 15:50:11 UTC
This is fixed by: https://github.com/ManageIQ/manageiq/pull/19890, that I forgot to link here.

Comment 9 Fabien Dupont 2020-04-23 18:03:42 UTC
Too late for 5.11.5, moving to 5.11.6.

Comment 10 CFME Bot 2020-05-01 23:35:15 UTC
New commit detected on ManageIQ/manageiq/jansa:

https://github.com/ManageIQ/manageiq/commit/e1ff082940e1602252024d5534818cacee1744a0
commit e1ff082940e1602252024d5534818cacee1744a0
Author:     Adam Grare <agrare>
AuthorDate: Fri Feb 28 20:37:55 2020 +0000
Commit:     Adam Grare <agrare>
CommitDate: Fri Feb 28 20:37:55 2020 +0000

    Merge pull request #19890 from fdupont-redhat/v2v_check_chost_in_throttler_apply_limits

    [V2V] Filter out jobs.migration_task.conversion_host.nil? in InfraConversionThrottler.running_conversions

    (cherry picked from commit da451b6898dfa29673d8b216239d43672bcae77c)

    https://bugzilla.redhat.com/show_bug.cgi?id=1819998

 app/models/infra_conversion_job.rb | 8 +-
 lib/infra_conversion_throttler.rb | 6 +
 spec/lib/infra_conversion_throttler_spec.rb | 42 +-
 3 files changed, 33 insertions(+), 23 deletions(-)

Comment 11 Fabien Dupont 2020-05-18 05:47:26 UTC
Backport PR: https://github.com/ManageIQ/manageiq/pull/20182

Comment 12 Nandini Chandra 2020-05-29 22:31:58 UTC
Verified in 5.11.6

Comment 15 errata-xmlrpc 2020-06-10 13:39:10 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:2480

Comment 16 Josh Carter 2020-10-01 13:45:41 UTC
*** Bug 1875034 has been marked as a duplicate of this bug. ***