Bug 1820068

Summary: Live snapshot fails and leave disks in locked state
Product: [oVirt] ovirt-engine Reporter: Tal Nisan <tnisan>
Component: BLL.StorageAssignee: Tal Nisan <tnisan>
Status: CLOSED CURRENTRELEASE QA Contact: Evelina Shames <eshames>
Severity: urgent Docs Contact:
Priority: unspecified    
Version: futureCC: aoconnor, bugs, eshames, lrotenbe, lsvaty, michal.skrivanek
Target Milestone: ovirt-4.4.0Flags: pm-rhel: ovirt-4.4+
aoconnor: blocker+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: rhv-4.4.0-30 Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-05-20 20:02:06 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1820016    
Bug Blocks: 1798072    

Description Tal Nisan 2020-04-02 08:06:10 UTC
Description of problem:
When performing live snapshot on a VM the operation fails and leave the disks in locked state

Version-Release number of selected component (if applicable):
4.4

How reproducible:
100%

Steps to Reproduce:
1. Perform live snapshot

Additional info:

2020-04-01 16:46:06,134+0200 INFO  (virt/80f9f8fd) [virt.vm] (vmId='ddb201fb-dccc-4d9f-8b7f-08cc66e0fece') Taking a live snapshot (drives=vdb,memory=True) (snapsh
ot:350)
2020-04-01 16:46:06,379+0200 WARN  (qgapoller/2) [virt.periodic.VmDispatcher] could not run <function QemuGuestAgentPoller.start.<locals>.per_vm_operation.<locals
>.<lambda> at 0x7f0e801c58c8> on ['ddb201fb-dccc-4d9f-8b7f-08cc66e0fece'] (periodic:289)
2020-04-01 16:46:06,469+0200 ERROR (virt/80f9f8fd) [virt.vm] (vmId='ddb201fb-dccc-4d9f-8b7f-08cc66e0fece') Unable to take snapshot (snapshot:354)
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/vdsm/virt/jobs/snapshot.py", line 351, in snapshot
    self.vm.run_dom_snapshot(snapxml, snap_flags)
  File "/usr/lib/python3.6/site-packages/vdsm/virt/vm.py", line 5567, in run_dom_snapshot
    self._dom.snapshotCreateXML(snapxml, snap_flags)
  File "/usr/lib/python3.6/site-packages/vdsm/virt/virdomain.py", line 101, in f
    ret = attr(*args, **kwargs)
  File "/usr/lib/python3.6/site-packages/vdsm/common/libvirtconnection.py", line 131, in wrapper
    ret = f(*args, **kwargs)
  File "/usr/lib/python3.6/site-packages/vdsm/common/function.py", line 94, in wrapper
    return func(inst, *args, **kwargs)
  File "/usr/lib64/python3.6/site-packages/libvirt.py", line 2800, in snapshotCreateXML
    if ret is None:raise libvirtError('virDomainSnapshotCreateXML() failed', dom=self)
libvirt.libvirtError: internal error: unable to execute QEMU command 'blockdev-add': Image is not in qcow2 format

Comment 1 Michal Skrivanek 2020-04-03 16:31:51 UTC
scratch build from linked bug fixes the problem, verified in OST

Comment 2 Benny Zlotnik 2020-04-06 09:41:50 UTC
*** Bug 1821001 has been marked as a duplicate of this bug. ***

Comment 4 Michal Skrivanek 2020-04-16 11:58:33 UTC
it's testable with current repos already, the patch attached to this bug is just a safeguard, not really required

Comment 5 Evelina Shames 2020-04-19 07:48:50 UTC
Verified on vdsm-4.40.13-1.el8ev.x86_64 and engine-4.4.0-0.32.master.el8ev

Comment 6 Sandro Bonazzola 2020-05-20 20:02:06 UTC
This bugzilla is included in oVirt 4.4.0 release, published on May 20th 2020.

Since the problem described in this bug report should be
resolved in oVirt 4.4.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.