Bug 1820068 - Live snapshot fails and leave disks in locked state
Summary: Live snapshot fails and leave disks in locked state
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Storage
Version: future
Hardware: Unspecified
OS: Unspecified
unspecified
urgent
Target Milestone: ovirt-4.4.0
: ---
Assignee: Tal Nisan
QA Contact: Evelina Shames
URL:
Whiteboard:
: 1821001 (view as bug list)
Depends On: 1820016
Blocks: 1798072
TreeView+ depends on / blocked
 
Reported: 2020-04-02 08:06 UTC by Tal Nisan
Modified: 2020-05-20 20:02 UTC (History)
6 users (show)

Fixed In Version: rhv-4.4.0-30
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-05-20 20:02:06 UTC
oVirt Team: Storage
Embargoed:
pm-rhel: ovirt-4.4+
aoconnor: blocker+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 108345 0 master MERGED spec: require libvirt with live snapshot fix 2021-01-21 22:47:01 UTC

Description Tal Nisan 2020-04-02 08:06:10 UTC
Description of problem:
When performing live snapshot on a VM the operation fails and leave the disks in locked state

Version-Release number of selected component (if applicable):
4.4

How reproducible:
100%

Steps to Reproduce:
1. Perform live snapshot

Additional info:

2020-04-01 16:46:06,134+0200 INFO  (virt/80f9f8fd) [virt.vm] (vmId='ddb201fb-dccc-4d9f-8b7f-08cc66e0fece') Taking a live snapshot (drives=vdb,memory=True) (snapsh
ot:350)
2020-04-01 16:46:06,379+0200 WARN  (qgapoller/2) [virt.periodic.VmDispatcher] could not run <function QemuGuestAgentPoller.start.<locals>.per_vm_operation.<locals
>.<lambda> at 0x7f0e801c58c8> on ['ddb201fb-dccc-4d9f-8b7f-08cc66e0fece'] (periodic:289)
2020-04-01 16:46:06,469+0200 ERROR (virt/80f9f8fd) [virt.vm] (vmId='ddb201fb-dccc-4d9f-8b7f-08cc66e0fece') Unable to take snapshot (snapshot:354)
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/vdsm/virt/jobs/snapshot.py", line 351, in snapshot
    self.vm.run_dom_snapshot(snapxml, snap_flags)
  File "/usr/lib/python3.6/site-packages/vdsm/virt/vm.py", line 5567, in run_dom_snapshot
    self._dom.snapshotCreateXML(snapxml, snap_flags)
  File "/usr/lib/python3.6/site-packages/vdsm/virt/virdomain.py", line 101, in f
    ret = attr(*args, **kwargs)
  File "/usr/lib/python3.6/site-packages/vdsm/common/libvirtconnection.py", line 131, in wrapper
    ret = f(*args, **kwargs)
  File "/usr/lib/python3.6/site-packages/vdsm/common/function.py", line 94, in wrapper
    return func(inst, *args, **kwargs)
  File "/usr/lib64/python3.6/site-packages/libvirt.py", line 2800, in snapshotCreateXML
    if ret is None:raise libvirtError('virDomainSnapshotCreateXML() failed', dom=self)
libvirt.libvirtError: internal error: unable to execute QEMU command 'blockdev-add': Image is not in qcow2 format

Comment 1 Michal Skrivanek 2020-04-03 16:31:51 UTC
scratch build from linked bug fixes the problem, verified in OST

Comment 2 Benny Zlotnik 2020-04-06 09:41:50 UTC
*** Bug 1821001 has been marked as a duplicate of this bug. ***

Comment 4 Michal Skrivanek 2020-04-16 11:58:33 UTC
it's testable with current repos already, the patch attached to this bug is just a safeguard, not really required

Comment 5 Evelina Shames 2020-04-19 07:48:50 UTC
Verified on vdsm-4.40.13-1.el8ev.x86_64 and engine-4.4.0-0.32.master.el8ev

Comment 6 Sandro Bonazzola 2020-05-20 20:02:06 UTC
This bugzilla is included in oVirt 4.4.0 release, published on May 20th 2020.

Since the problem described in this bug report should be
resolved in oVirt 4.4.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.