Bug 1821503

Summary:	/readyz should start reporting failure on shutdown initiation
Product:	OpenShift Container Platform	Reporter:	Abu Kashem <akashem>
Component:	openshift-apiserver	Assignee:	Abu Kashem <akashem>
Status:	CLOSED WONTFIX	QA Contact:	Xingxing Xia <xxia>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	4.4	CC:	aos-bugs, mfojtik, xxia
Target Milestone:	---
Target Release:	4.1.z
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1821502	Environment:
Last Closed:	2020-05-18 15:35:00 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1811202, 1821500, 1821502
Bug Blocks:

Description Abu Kashem 2020-04-07 00:02:51 UTC

+++ This bug was initially created as a clone of Bug #1821502 +++

+++ This bug was initially created as a clone of Bug #1821500 +++

This bug was initially created as a copy of Bug #1811202

I am copying this bug because: 



+++ This bug was initially created as a clone of Bug #1811169 +++

Description of problem:

Currently, /readyz starts reporting failure after ShutdownDelayDuration elapses. The load balancer(s) uses /readyz for health check and are not aware of the shutdown initiation until ShutdownDelayDuration elapses. This does not give the load balancer(s) enough time to detect and react to it.

We expect /readyz to start returning failure as soon as apiserver shutdown is initiated(SIGTERM received). This gives the load balancer a window (defined by ShutdownDelayDuration) to detect that /readyz is red and stop sending traffic to this server.


How reproducible:
Always


upstream PR: https://github.com/kubernetes/kubernetes/pull/88911

Comment 1 Michal Fojtik 2020-05-12 10:47:25 UTC

This bug hasn't had any activity in the last 30 days. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

As such, we're marking this bug as "LifecycleStale".

If you have further information on the current state of the bug, please update it, otherwise this bug will be automatically closed in 7 days. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

Comment 2 Abu Kashem 2020-05-18 15:07:41 UTC

I don't think it's worth porting /readyz in openshift-apiserver 4.1. /readyz fix is available in "1.17.4" or later in upstream. openshift-apiserver 4.1 uses an older version of upstream. Unless a customer raises this as a critical issues I don't think it's worth.

Comment 3 Abu Kashem 2020-05-18 15:08:14 UTC

FYI, OpenShift 4.1 is pinned to 1.13.4.

Comment 4 Abu Kashem 2020-05-18 15:35:00 UTC

closing it for now, the efforts involved is not worth the bang for the buck. We can reassess this if and when an important customer wants it.