Bug 1821502 - /readyz should start reporting failure on shutdown initiation
Summary: /readyz should start reporting failure on shutdown initiation
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: openshift-apiserver
Version: 4.4
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 4.2.z
Assignee: Abu Kashem
QA Contact: Xingxing Xia
URL:
Whiteboard:
Depends On: 1811202 1821500
Blocks: 1821503
TreeView+ depends on / blocked
 
Reported: 2020-04-07 00:01 UTC by Abu Kashem
Modified: 2020-05-18 15:35 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1821500
: 1821503 (view as bug list)
Environment:
Last Closed: 2020-05-18 15:35:48 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Abu Kashem 2020-04-07 00:01:03 UTC
+++ This bug was initially created as a clone of Bug #1821500 +++

This bug was initially created as a copy of Bug #1811202

I am copying this bug because: 



+++ This bug was initially created as a clone of Bug #1811169 +++

Description of problem:

Currently, /readyz starts reporting failure after ShutdownDelayDuration elapses. The load balancer(s) uses /readyz for health check and are not aware of the shutdown initiation until ShutdownDelayDuration elapses. This does not give the load balancer(s) enough time to detect and react to it.

We expect /readyz to start returning failure as soon as apiserver shutdown is initiated(SIGTERM received). This gives the load balancer a window (defined by ShutdownDelayDuration) to detect that /readyz is red and stop sending traffic to this server.


How reproducible:
Always


upstream PR: https://github.com/kubernetes/kubernetes/pull/88911

Comment 1 Michal Fojtik 2020-05-12 10:47:18 UTC
This bug hasn't had any activity in the last 30 days. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

As such, we're marking this bug as "LifecycleStale".

If you have further information on the current state of the bug, please update it, otherwise this bug will be automatically closed in 7 days. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

Comment 2 Abu Kashem 2020-05-18 15:03:17 UTC
Not sure why the "Target Release" of the BZ has been reset. Looking at the history, it was set for "4.2.z".

openshift-apiserver 4.2 uses "1.14.0" - https://github.com/openshift/openshift-apiserver/blob/release-4.2/glide.yaml#L12
/readyz fix is available in "1.17.4" or later in upstream. 

I think we are not going to move openshift-apiserver 4.2 from "1.14.0" to "1.17.4".

Comment 3 Abu Kashem 2020-05-18 15:35:48 UTC
closing it for now, the efforts involved is not worth the bang for the buck. We can reassess this if and when an important customer wants it.


Note You need to log in before you can comment on or make changes to this bug.