Bug 182161

Summary: Error in /etc/init.d/vncserver script
Product: [Fedora] Fedora Reporter: Michael Rensing <michael.rensing>
Component: vncAssignee: Radek Vokál <rvokal>
Status: CLOSED RAWHIDE QA Contact: David Lawrence <dkl>
Severity: medium Docs Contact:
Priority: medium    
Version: 4CC: rdieter
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 4.1.1-36 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-03-01 13:52:00 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Michael Rensing 2006-02-20 20:43:05 UTC
Description of problem:
When the vncserver init.d script runs with the default configuration as
installed, the script fails to start the server, but the message returns "OK"
instead of "FAILED"

Version-Release number of selected component (if applicable):
vnc 4.1.1-10.1

How reproducible:
100%

Steps to Reproduce:
1. Comment out any parameters in /etc/sysconfig/vncservers (this is the default
installed from rpm)
2. 'service vncservers start' (will say "OK")
3. 'service vncservers status' (will say "Xvnc is stopped")
  
Actual results:
see above

Expected results:
'service vncservers start' should say "FAILED"


Additional info:
The problem is that there are no VNCSERVERS defined in /etc/sysconfig/vncservers.


One solution is to add a line to /etc/init.d/vncservers just before starting the
displays and test to see if any VNCSERVERS are defined:

    [ "$VNCSERVERS" = "" ] && RETVAL=1
    for display in ${VNCSERVERS}

Comment 1 Jitka Kozana 2006-03-01 13:52:00 UTC
With default cofiguration, no displays will be configured, but vncserver was     
started with no problems, that's why      
/etc/init.d/vncserver start      
says "OK" and      
/etc/init.d/vncserver status    
says "Xvnc is stopped".   
   
Now /etc/init.d/vncserver start will say  
Starting VNC server:no displays configured      [  OK  ]   
 
   
     

Comment 2 Rex Dieter 2006-03-01 14:04:25 UTC
IMO, if the service fails to properly start (for any reason, "no displays
configured" or otherwise), it should *not* report [ OK ].