Bug 1821860
Summary: | [4.4] Build incorrectly substitutes "=" for spaces in Dockerfiles | |||
---|---|---|---|---|
Product: | OpenShift Container Platform | Reporter: | Adam Kaplan <adam.kaplan> | |
Component: | Build | Assignee: | Nalin Dahyabhai <nalin> | |
Status: | CLOSED ERRATA | QA Contact: | wewang <wewang> | |
Severity: | medium | Docs Contact: | ||
Priority: | unspecified | |||
Version: | 4.2.z | CC: | aos-bugs, nalin, wewang, wzheng | |
Target Milestone: | --- | |||
Target Release: | 4.4.0 | |||
Hardware: | Unspecified | |||
OS: | Unspecified | |||
Whiteboard: | ||||
Fixed In Version: | Doc Type: | Bug Fix | ||
Doc Text: |
Cause: Before starting a build, the OpenShift builder would parse the supplied Dockerfile and reconstruct a modified version of it to use for the build, to add labels and handle substitutions of the images named in FROM instructions. The generated Dockerfile did not always correctly reconstruct ENV and LABEL instructions.
Consequence:
The generated Dockerfile would sometimes include "=" characters where the original did not, and the build would fail with a syntax error.
Fix:
When generating the modified Dockerfile, the original text for ENV and LABEL instructions is now used verbatim.
Result:
The build process should no longer introduce syntax errors in ENV and LABEL instructions.
|
Story Points: | --- | |
Clone Of: | 1821858 | |||
: | 1821861 (view as bug list) | Environment: | ||
Last Closed: | 2020-05-04 11:48:34 UTC | Type: | --- | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: | ||||
Bug Depends On: | 1821858 | |||
Bug Blocks: | 1821861 |
Description
Adam Kaplan
2020-04-07 18:17:04 UTC
Verified in version: 4.4.0-0.nightly-2020-04-18-095545 STEP 17: ENV JAVA_OPTS -server -Djava.net.preferIPv4Stack=true f53bb24a95edb80f540a39b24874d9a8fc016874bc6be8546b65fb36a40e8438 STEP 18: ENV LAUNCHER_CONF ./conf/jetty.xml ./conf/jetty-requestlog.xml d07f2d4b8d3afb3dc32858b5b8a23f2699657da05aeb33a55aa52f9a4ba68b85 STEP 19: CMD java -Dnexus-work=${SONATYPE_WORK} -Dnexus-webapp-context-path=${CONTEXT_PATH} -Xms${MIN_HEAP} -Xmx${MAX_HEAP} -cp 'conf/:lib/*' ${JAVA_OPTS} org.sonatype.nexus.bootstrap.Launcher ${LAUNCHER_CONF} a72c275e1e8161ec0763bc3bdc250e230cde4d853e02003e541bd535e26b220b STEP 20: ENV "OPENSHIFT_BUILD_NAME"="docker-nexus-1" "OPENSHIFT_BUILD_NAMESPACE"="wewang" "OPENSHIFT_BUILD_SOURCE"="https://github.com/sonatype/docker-nexus.git" "OPENSHIFT_BUILD_COMMIT"="863887b46ddb91b5fa8313e48b4678e3e4af293b" Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2020:0581 |