+++ This bug was initially created as a clone of Bug #1821860 +++ +++ This bug was initially created as a clone of Bug #1821858 +++ Description of problem: When rewriting the Dockerfile with our substitutions, we unconditionally insert = characters, even in cases where the original file didn't use them. They're syntactically important, though, so such changes can cause builds to fail. For ENV and LABEL instructions, just emit the original text. Reported in openshift/origin#24151 [1]. Fixed by openshift/builder#134 [2] Version-Release number of selected component (if applicable): 4.2.z How reproducible: Always Steps to Reproduce: 1. Create Docker fbuild from e.g. git url: https://github.com/sonatype/docker-nexus.git context dir: /oss 2. Start build Actual results: ``` Cloning "https://github.com/sonatype/docker-nexus.git" ... Commit: b892177cfb8b03d1d37a369b47ec57512051d67b (Update Repository Manager to 2.14.15-01.) Author: Sonatype sonatype-ci Date: Tue Oct 15 13:50:45 2019 +0000 Caching blobs under "/var/cache/blobs". error: build error: Syntax error - can't find = in "./conf/jetty-requestlog.xml". Must be of the form: name=value ``` Expected results: Build succeeds Additional info: [1] https://github.com/openshift/origin/issues/24151 [2] https://github.com/openshift/builder/pull/134
Pr just merged 3 hours ago, wait latest payload include the pr.
Verified in version: 4.3.0-0.nightly-2020-04-25-134334 Logs: STEP 16: ENV MIN_HEAP 256m c0b2b8a3fd6524bc2f9451f554f797c69f3d472a404eb5fec1effdf2ee7d573f STEP 17: ENV JAVA_OPTS -server -Djava.net.preferIPv4Stack=true 3c5f1c0bb801e81e553bdac88c56c38f2b7228aa851c1df01554b3fb4e540379 STEP 18: ENV LAUNCHER_CONF ./conf/jetty.xml ./conf/jetty-requestlog.xml 8008f5de2e2af67ce0bf7caf68394e4bacd2cf46a58abd91e2f4405ca87a3371 STEP 19: CMD java -Dnexus-work=${SONATYPE_WORK} -Dnexus-webapp-context-path=${CONTEXT_PATH} -Xms${MIN_HEAP} -Xmx${MAX_HEAP} -cp 'conf/:lib/*' ${JAVA_OPTS} org.sonatype.nexus.bootstrap.Launcher ${LAUNCHER_CONF} 43d66d77f448137b8c12699192fb63bcb4e013082a4956cd3b16317a42f03ce8
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2020:2006