Bug 1826020

Summary: PCP_NSSDB_DIR should not be mentioned in /etc/pcp.conf
Product: Red Hat Enterprise Linux 8 Reporter: Carlos Santos <casantos>
Component: pcpAssignee: Andreas Gerstmayr <agerstmayr>
Status: CLOSED DUPLICATE QA Contact: Jan Kurik <jkurik>
Severity: low Docs Contact:
Priority: unspecified    
Version: 8.3CC: agerstmayr, b.prins, jkurik, mgoodwin, nathans, patrickm
Target Milestone: rcKeywords: Triaged
Target Release: 8.3Flags: pm-rhel: mirror+
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 5.1.1 Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-04-29 23:55:11 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Carlos Santos 2020-04-20 17:13:47 UTC
Description of problem:

The default pcp.conf contains the following lines

    # directory for PCP specific nssdb
    # Standard path: /etc/pcp/nssdb
    PCP_NSSDB_DIR=/etc/pcp/nssdb

Actually PCP_NSSDB_DIR is not used anywhere. According to pmintro(1)

    PCP_SECURE_DB_PATH
        When set, this variable specifies an alternate certficate database path
        for client tools.  Similar to the action of the -C option for pmcd(1)
        and pmproxy(1).

Version-Release number of selected component (if applicable):

    # cat /etc/redhat-release 
    Red Hat Enterprise Linux Server release 7.8 (Maipo)

    # rpm -qf /etc/pcp.conf 
    pcp-conf-4.3.2-6.el7.x86_64

How reproducible: Always

Steps to Reproduce: not appliccable

Actual results: pcp.conf by default contains incorrect information.

Expected results: the file should not contain incorrect information.

Additional info:

The misleading information led a customer to waste time attempting to set
secure communication between pmlogger and a remote pmdc.

Comment 3 Andreas Gerstmayr 2020-04-28 17:06:42 UTC
Fixed in upstream with commit:

commit 5890d31f0e07b03bd8a3c602be31f339269b14a5 (HEAD -> master, upstream/master, origin/master, origin/HEAD)
Author: Andreas Gerstmayr <agerstmayr>
Date:   Tue Apr 28 18:30:21 2020 +0200

    rename PCP_NSSDB_DIR to PCP_SECURE_DB_PATH in pcp.conf
    
    There was no reference to PCP_NSSDB_DIR in the source code, only to
    PCP_SECURE_DB_PATH. pcpintro(1) also references PCP_SECURE_DB_PATH.
    
    Resolves Red Hat BZ #1826020

Comment 5 Nathan Scott 2020-04-29 23:55:11 UTC
Will be resolved via rebase to pcp-5.1 in RHEL 8.3.

*** This bug has been marked as a duplicate of bug 1792971 ***

Comment 6 Jan Kurik 2020-06-12 15:55:17 UTC
Verified on pcp-5.1.1-2.el8 build.