Bug 1827050

Summary: Operators may not respond to spec changes in managed deployments or daemonsets
Product: OpenShift Container Platform Reporter: Maru Newby <mnewby>
Component: openshift-apiserverAssignee: Maru Newby <mnewby>
Status: CLOSED ERRATA QA Contact: Xingxing Xia <xxia>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.5CC: aos-bugs, mfojtik, nagrawal
Target Milestone: ---   
Target Release: 4.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of:
: 1827051 (view as bug list) Environment:
Last Closed: 2020-07-13 17:30:26 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1827051, 1827052    

Description Maru Newby 2020-04-23 07:08:33 UTC 
Operators that rely on library-go's Apply{DaemonSet,Deployment} function were previously responsible for detecting changes to a managed resource's spec or changes to external resources and forcing a reload. All operators should be updated to use the revised Apply* methods recently merged to library-go [1] to ensure consistent behavior in responding to changes in external resources or changes to the spec of a managed deployment or daemonset.

1: https://github.com/openshift/library-go/pull/773
Comment 1 Maru Newby 2020-05-20 14:19:12 UTC 
Still need to update the service ca operator for 4.5.
Comment 4 Maru Newby 2020-05-21 19:43:51 UTC 
Note that this is an umbrella bz. As per the linked github PRs, if testing is to be done, it should be done for all updated operators.
Comment 5 Xingxing Xia 2020-06-19 12:08:35 UTC 
No regression issue found related in QE latest 4.5 nightly builds' functional tests and upgrade tests so far.
Specifically take openshiftapiserver for example, rolling out has no regression issue (tested in 4.5.0-0.nightly-2020-06-18-210518 env)
$ oc edit project.config cluster # add below
...
spec:
  projectRequestMessage: xxia test projectRequestMessage change
...

$ oc get openshiftapiserver cluster -o yaml
...
spec:
...
    projectConfig:
      projectRequestMessage: xxia test projectRequestMessage change
...

$ oc get po -n openshift-apiserver # can see rolling out success.
Comment 7 errata-xmlrpc 2020-07-13 17:30:26 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409