Bug 1827051

Summary:	[4.4] Operators may not respond to spec changes in managed deployments or daemonsets
Product:	OpenShift Container Platform	Reporter:	Maru Newby <mnewby>
Component:	kube-apiserver	Assignee:	Maru Newby <mnewby>
Status:	CLOSED WONTFIX	QA Contact:	Xingxing Xia <xxia>
Severity:	medium	Docs Contact:
Priority:	low
Version:	4.4	CC:	aos-bugs, mfojtik, xxia
Target Milestone:	---	Flags:	mfojtik: needinfo?
Target Release:	4.4.z
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	LifecycleReset
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1827050
Clones:	1827052 (view as bug list)		Environment:
Last Closed:	2020-08-31 14:00:15 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1827050
Bug Blocks:	1827052

Description Maru Newby 2020-04-23 07:12:46 UTC

+++ This bug was initially created as a clone of Bug #1827050 +++

Operators that rely on library-go's Apply{DaemonSet,Deployment} function were previously responsible for detecting changes to a managed resource's spec or changes to external resources and forcing a reload. All operators should be updated to use the revised Apply* methods recently merged to library-go [1] to ensure consistent behavior in responding to changes in external resources or changes to the spec of a managed deployment or daemonset.

1: https://github.com/openshift/library-go/pull/773

Comment 1 Maru Newby 2020-05-20 14:37:24 UTC

The 4.5 fixes are nearly in, will get started on backporting merged fixes to 4.4.

Comment 2 Maru Newby 2020-06-18 14:29:08 UTC

I’m adding UpcomingSprint, because I was occupied by fixing bugs with higher priority/severity, developing new features with higher priority, or developing new features to improve stability at a macro level. I will revisit this bug next sprint.

The library-go backport has already merged, operators just need to be bumped.

Comment 3 Maru Newby 2020-07-10 21:54:30 UTC

I’m adding UpcomingSprint, because I was occupied by fixing bugs with higher priority/severity, developing new features with higher priority, or developing new features to improve stability at a macro level. I will revisit this bug next sprint.

Comment 4 Maru Newby 2020-07-31 16:35:00 UTC

I’m adding UpcomingSprint, because I was occupied by fixing bugs with higher priority/severity, developing new features with higher priority, or developing new features to improve stability at a macro level. I will revisit this bug next sprint.

Comment 5 Maru Newby 2020-08-22 01:42:37 UTC

This bug will be evaluated next sprint.

Comment 6 Michal Fojtik 2020-08-24 13:12:43 UTC

This bug hasn't had any activity in the last 30 days. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're marking this bug as "LifecycleStale" and decreasing the severity/priority. If you have further information on the current state of the bug, please update it, otherwise this bug can be closed in about 7 days. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

Comment 7 Michal Fojtik 2020-08-31 14:00:15 UTC

This bug hasn't had any activity 7 days after it was marked as LifecycleStale, so we are closing this bug as WONTFIX. If you consider this bug still valuable, please reopen it or create new bug.

Comment 8 Michal Fojtik 2020-08-31 15:00:13 UTC

The LifecycleStale keyword was removed because the bug got commented on recently.
The bug assignee was notified.