Bug 1827130

Summary:	Use library-go for DaemonSet/Deployment change detection
Product:	OpenShift Container Platform	Reporter:	Jan Safranek <jsafrane>
Component:	Storage	Assignee:	Jan Safranek <jsafrane>
Status:	CLOSED ERRATA	QA Contact:	Qin Ping <piqin>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4.5	CC:	aos-bugs
Target Milestone:	---
Target Release:	4.5.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-07-13 17:30:50 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jan Safranek 2020-04-23 10:10:35 UTC

Description of problem:

The operator now detects changes in the driver Deployment or DaemonSet by checking hashsum of the previous "requested" objects.Spec with current "requested" object.Spec.

https://github.com/openshift/aws-ebs-csi-driver-operator/blob/master/pkg/operator/sync.go#L66-L72

The same check is now available in library-go. The operator should stop using its custom code and rely on library-go that has broader community and will get fixed / tested by more operators.

https://github.com/openshift/library-go/pull/773

There is no user / QA visible change to test this "bug".

Comment 3 Qin Ping 2020-05-09 12:02:59 UTC

The PR LGTM, so marked this bug as verified.

Comment 4 errata-xmlrpc 2020-07-13 17:30:50 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409