Bug 1827130 - Use library-go for DaemonSet/Deployment change detection
Summary: Use library-go for DaemonSet/Deployment change detection
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Storage
Version: 4.5
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.5.0
Assignee: Jan Safranek
QA Contact: Qin Ping
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-04-23 10:10 UTC by Jan Safranek
Modified: 2020-07-13 17:31 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-07-13 17:30:50 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift aws-ebs-csi-driver-operator pull 49 0 None closed Bug 1827130: Rebase to new library-go 2020-07-01 09:12:32 UTC
Red Hat Product Errata RHBA-2020:2409 0 None None None 2020-07-13 17:31:03 UTC

Description Jan Safranek 2020-04-23 10:10:35 UTC
Description of problem:

The operator now detects changes in the driver Deployment or DaemonSet by checking hashsum of the previous "requested" objects.Spec with current "requested" object.Spec.

https://github.com/openshift/aws-ebs-csi-driver-operator/blob/master/pkg/operator/sync.go#L66-L72

The same check is now available in library-go. The operator should stop using its custom code and rely on library-go that has broader community and will get fixed / tested by more operators.

https://github.com/openshift/library-go/pull/773

There is no user / QA visible change to test this "bug".

Comment 3 Qin Ping 2020-05-09 12:02:59 UTC
The PR LGTM, so marked this bug as verified.

Comment 4 errata-xmlrpc 2020-07-13 17:30:50 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409


Note You need to log in before you can comment on or make changes to this bug.