Bug 1827341

Summary:	Review Request: golang-github-cpuguy83-md2man-2 - converts markdown into roff
Product:	[Fedora] Fedora	Reporter:	Andreas Gerstmayr <agerstmayr>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	mail, mgoodwin, nathans, package-review
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-04-24 20:21:22 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1827343

Description Andreas Gerstmayr 2020-04-23 17:04:54 UTC

Spec URL: https://github.com/andreasgerstmayr/specs/raw/master/reviews/rpms/golang-gopkg-cpuguy83-md2man-2/golang-gopkg-cpuguy83-md2man-2.spec
SRPM URL: https://github.com/andreasgerstmayr/specs/raw/master/reviews/rpms/golang-gopkg-cpuguy83-md2man-2/golang-gopkg-cpuguy83-md2man-2-2.0.0-1.fc31.src.rpm
Description: Converts markdown into roff (man pages)
Fedora Account System Username: agerstmayr

The current package golang-github-cpuguy83-md2man packages version 2.0.0 already, however it provides only the following go paths:

golang(github.com/cpuguy83/go-md2man/md2man) = 2.0.0-0.4.20190624gitf79a8a8.fc31
golang(github.com/cpuguy83/go-md2man/md2man)(commit=f79a8a8ca69da163eee19ab442bedad7a35bba5a) = 2.0.0-0.4.20190624gitf79a8a8.fc31
golang-github-cpuguy83-md2man-devel = 2.0.0-0.4.20190624gitf79a8a8.fc31
golang-ipath(github.com/cpuguy83/go-md2man) = 2.0.0-0.4.20190624gitf79a8a8.fc31
golang-ipath(github.com/cpuguy83/go-md2man)(commit=f79a8a8ca69da163eee19ab442bedad7a35bba5a) = 2.0.0-0.4.20190624gitf79a8a8.fc31


afaics the correct Go import path for version 2.0.0 would be:
github.com/cpuguy83/go-md2man/v2/md2man
... which is required by another golang package (golang-github-urfave-cli-2), and exported by the spec file of this review request.

Comment 1 Andreas Gerstmayr 2020-04-23 18:29:28 UTC

Spec URL: https://github.com/andreasgerstmayr/specs/raw/master/reviews/rpms/golang-github-cpuguy83-md2man-2/golang-github-cpuguy83-md2man-2.spec
SRPM URL: https://github.com/andreasgerstmayr/specs/raw/master/reviews/rpms/golang-github-cpuguy83-md2man-2/golang-github-cpuguy83-md2man-2-2.0.0-1.fc31.src.rpm

Comment 2 Fabian Affolter 2020-04-24 07:52:07 UTC

I don't need this package for golang-github-urfave-cli-2 (https://bugzilla.redhat.com/show_bug.cgi?id=1821645) as the requirement is fixed in the spec file.

Comment 3 Andreas Gerstmayr 2020-04-24 20:21:22 UTC

(In reply to Fabian Affolter from comment #2)
> I don't need this package for golang-github-urfave-cli-2
> (https://bugzilla.redhat.com/show_bug.cgi?id=1821645) as the requirement is
> fixed in the spec file.

Seems a bit hacky, but I've implemented the same now with an explicit
BuildRequires: golang(github.com/cpuguy83/go-md2man/md2man) >= 2.0.0

Imho golang-github-cpuguy83-md2man shouldn't have packaged version 2
(or be renamed to golang-github-cpuguy83-md2man-2 with the updated Go import path).

@Fabian I'll start builds of urfave/cli for F31, F32 and F33 - if you need more, just ping me.