Bug 1827341 - Review Request: golang-github-cpuguy83-md2man-2 - converts markdown into roff
Summary: Review Request: golang-github-cpuguy83-md2man-2 - converts markdown into roff
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1827343
TreeView+ depends on / blocked
 
Reported: 2020-04-23 17:04 UTC by Andreas Gerstmayr
Modified: 2020-04-24 20:21 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-04-24 20:21:22 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Andreas Gerstmayr 2020-04-23 17:04:54 UTC
Spec URL: https://github.com/andreasgerstmayr/specs/raw/master/reviews/rpms/golang-gopkg-cpuguy83-md2man-2/golang-gopkg-cpuguy83-md2man-2.spec
SRPM URL: https://github.com/andreasgerstmayr/specs/raw/master/reviews/rpms/golang-gopkg-cpuguy83-md2man-2/golang-gopkg-cpuguy83-md2man-2-2.0.0-1.fc31.src.rpm
Description: Converts markdown into roff (man pages)
Fedora Account System Username: agerstmayr

The current package golang-github-cpuguy83-md2man packages version 2.0.0 already, however it provides only the following go paths:

golang(github.com/cpuguy83/go-md2man/md2man) = 2.0.0-0.4.20190624gitf79a8a8.fc31
golang(github.com/cpuguy83/go-md2man/md2man)(commit=f79a8a8ca69da163eee19ab442bedad7a35bba5a) = 2.0.0-0.4.20190624gitf79a8a8.fc31
golang-github-cpuguy83-md2man-devel = 2.0.0-0.4.20190624gitf79a8a8.fc31
golang-ipath(github.com/cpuguy83/go-md2man) = 2.0.0-0.4.20190624gitf79a8a8.fc31
golang-ipath(github.com/cpuguy83/go-md2man)(commit=f79a8a8ca69da163eee19ab442bedad7a35bba5a) = 2.0.0-0.4.20190624gitf79a8a8.fc31


afaics the correct Go import path for version 2.0.0 would be:
github.com/cpuguy83/go-md2man/v2/md2man
... which is required by another golang package (golang-github-urfave-cli-2), and exported by the spec file of this review request.

Comment 2 Fabian Affolter 2020-04-24 07:52:07 UTC
I don't need this package for golang-github-urfave-cli-2 (https://bugzilla.redhat.com/show_bug.cgi?id=1821645) as the requirement is fixed in the spec file.

Comment 3 Andreas Gerstmayr 2020-04-24 20:21:22 UTC
(In reply to Fabian Affolter from comment #2)
> I don't need this package for golang-github-urfave-cli-2
> (https://bugzilla.redhat.com/show_bug.cgi?id=1821645) as the requirement is
> fixed in the spec file.

Seems a bit hacky, but I've implemented the same now with an explicit
BuildRequires: golang(github.com/cpuguy83/go-md2man/md2man) >= 2.0.0

Imho golang-github-cpuguy83-md2man shouldn't have packaged version 2
(or be renamed to golang-github-cpuguy83-md2man-2 with the updated Go import path).

@Fabian I'll start builds of urfave/cli for F31, F32 and F33 - if you need more, just ping me.


Note You need to log in before you can comment on or make changes to this bug.