Bug 1827343

Spec URL: https://github.com/andreasgerstmayr/specs/raw/master/reviews/rpms/golang-github-urfave-cli-2/golang-github-urfave-cli-2.spec
SRPM URL: https://github.com/andreasgerstmayr/specs/raw/master/reviews/rpms/golang-github-urfave-cli-2/golang-github-urfave-cli-2-2.2.0-1.fc31.src.rpm

Looks good to me Andreas.  I think the rpmlint URL issues below may be just artifacts of using the golang macros and the need to package v2 APIs?  Minor issue of course - maybe double-check it, but its an Ack from me either way.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


===== MUST items =====

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Rpmlint is run on all rpms the build produces.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
[x]: Spec file according to URL is the same as in SRPM.




Rpmlint
-------
Checking: golang-github-urfave-cli-2-devel-2.2.0-1.fc31.noarch.rpm
          golang-github-urfave-cli-2-2.2.0-1.fc31.src.rpm
golang-github-urfave-cli-2-devel.noarch: W: invalid-url URL: https://github.com/urfave/cli/v2 HTTP Error 404: Not Found
golang-github-urfave-cli-2-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/urfave/cli/v2/.goipath
golang-github-urfave-cli-2.src: W: invalid-url URL: https://github.com/urfave/cli/v2 HTTP Error 404: Not Found
golang-github-urfave-cli-2.src: W: no-%build-section
2 packages and 0 specfiles checked; 0 errors, 4 warnings.




Source checksums
----------------
https://github.com/urfave/cli/archive/v2.2.0/cli-2.2.0.tar.gz :
  CHECKSUM(SHA256) this package     : 5c3717e403ec924011513cfb7542360c156ef1e4222ca21697198ca47f5ca731
  CHECKSUM(SHA256) upstream package : 5c3717e403ec924011513cfb7542360c156ef1e4222ca21697198ca47f5ca731


Requires
--------
golang-github-urfave-cli-2-devel (rpmlib, GLIBC filtered):
    go-filesystem
    golang(github.com/BurntSushi/toml)
    golang(github.com/cpuguy83/go-md2man/v2/md2man)
    golang(gopkg.in/yaml.v2)



Provides
--------
golang-github-urfave-cli-2-devel:
    golang(github.com/urfave/cli/v2)
    golang(github.com/urfave/cli/v2/altsrc)
    golang-github-urfave-cli-2-devel
    golang-ipath(github.com/urfave/cli/v2)



Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16
Command line :/usr/bin/fedora-review -p -n golang-github-urfave-cli-2
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Python, Ocaml, Perl, Haskell, SugarActivity, C/C++, fonts, R, PHP, Java
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

This a duplicate review request of https://bugzilla.redhat.com/show_bug.cgi?id=1821645.

This is...sorry

Thanks for the review!
Imho as long as spectool is able to download the correct URL, it should be fine :)


(In reply to Fabian Affolter from comment #3)
> This a duplicate review request of
> https://bugzilla.redhat.com/show_bug.cgi?id=1821645.

Oh sorry, I didn't see that - I checked if the package already exists, but forgot to check for existing review requests - my bad.
As Nathan took the time to review this spec already (and it's very similar), I'll go forward with this one - next time I'll check for existing review requests before I open a new one.


Cheers,
Andreas

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-urfave-cli-2