Bug 1827601

Summary:	vSphere - Return error on empty task reference
Product:	OpenShift Container Platform	Reporter:	Alexander Demicev <ademicev>
Component:	Cloud Compute	Assignee:	Alexander Demicev <ademicev>
Cloud Compute sub component:	Other Providers	QA Contact:	Milind Yadav <miyadav>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	unspecified
Priority:	low	CC:	jspeed
Version:	4.5
Target Milestone:	---
Target Release:	4.5.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-07-13 17:31:14 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Alexander Demicev 2020-04-24 10:01:14 UTC

Description of problem:

It's better to return an error on empty task reference. Returning nil without any error means we need to check the returned task for nil every time and it also brings a bit of confusion to code.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 3 Milind Yadav 2020-05-04 02:46:55 UTC

Please help on steps to reproduce

Comment 4 Milind Yadav 2020-05-05 10:19:44 UTC

More like a code debt / tech debt , cannot validate functional change . Hence moving to VERIFIED.

Comment 5 Milind Yadav 2020-05-05 10:31:58 UTC

Alex provided info --these changes  makes controller code safer

Comment 6 errata-xmlrpc 2020-07-13 17:31:14 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409