Bug 1827601 - vSphere - Return error on empty task reference
Summary: vSphere - Return error on empty task reference
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Cloud Compute
Version: 4.5
Hardware: Unspecified
OS: Unspecified
low
unspecified
Target Milestone: ---
: 4.5.0
Assignee: Alexander Demicev
QA Contact: Milind Yadav
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-04-24 10:01 UTC by Alexander Demicev
Modified: 2020-07-13 17:31 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-07-13 17:31:14 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift machine-api-operator pull 567 0 None closed Bug 1827601: vSphere - Return error on empty task reference 2020-06-23 10:22:43 UTC
Red Hat Product Errata RHBA-2020:2409 0 None None None 2020-07-13 17:31:28 UTC

Description Alexander Demicev 2020-04-24 10:01:14 UTC
Description of problem:

It's better to return an error on empty task reference. Returning nil without any error means we need to check the returned task for nil every time and it also brings a bit of confusion to code.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 3 Milind Yadav 2020-05-04 02:46:55 UTC
Please help on steps to reproduce

Comment 4 Milind Yadav 2020-05-05 10:19:44 UTC
More like a code debt / tech debt , cannot validate functional change . Hence moving to VERIFIED.

Comment 5 Milind Yadav 2020-05-05 10:31:58 UTC
Alex provided info --these changes  makes controller code safer

Comment 6 errata-xmlrpc 2020-07-13 17:31:14 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409


Note You need to log in before you can comment on or make changes to this bug.