Bug 1829479

Summary: octavia::wsgi::apache::server_name should be octavia::wsgi::apache::servername in puppet/services/octavia-api.yaml
Product: Red Hat OpenStack Reporter: Matt Flusche <mflusche>
Component: openstack-tripleo-heat-templatesAssignee: Brent Eagles <beagles>
Status: CLOSED ERRATA QA Contact: Omer Schwartz <oschwart>
Severity: high Docs Contact:
Priority: high    
Version: 13.0 (Queens)CC: bbonguar, emacchi, gthiemon, jgrosso, mburns, oschwart
Target Milestone: zstreamKeywords: Triaged, ZStream
Target Release: 13.0 (Queens)   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: openstack-tripleo-heat-templates-8.4.1-58.1.el7ost.noarch.rpm Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-10-28 18:23:44 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Matt Flusche 2020-04-29 15:47:38 UTC
Description of problem:

hiera parameter octavia::wsgi::apache::server_name should be octavia::wsgi::apache::servername in puppet/services/octavia-api.yaml to match the parameter in the puppet module.  Currently, always set to $::fqdn


 grep "server.*name" /usr/share/openstack-tripleo-heat-templates/puppet/services/octavia-api.yaml
            octavia::wsgi::apache::server_name:


$ grep -A3 "server.*name" /etc/puppet/modules/octavia/manifests/wsgi/apache.pp                                                   
# [*servername*]
#   (Optional) The servername for the virtualhost.
#   Defaults to $::fqdn
#
# [*port*]
--
  $servername                  = $::fqdn,
  $port                        = 9876,
  $bind_host                   = undef,
  $path                        = '/',
--
    servername                  => $servername,
    ssl                         => $ssl,
    ssl_ca                      => $ssl_ca,
    ssl_cert                    => $ssl_cert,


Version-Release number of selected component (if applicable):

OSP 13

openstack-tripleo-heat-templates-8.4.1-51.el7ost.noarch (current)
puppet-octavia-12.4.0-15.el7ost.noarch (current)


How reproducible:
100%


Steps to Reproduce:
1.  Deploy with octavia & note the hiera config does not match the config for octavia httpd config on the controllers 

sudo hiera -c /etc/puppet/hiera.yaml octavia::wsgi::apache::server_name
sudo grep ServerName /var/lib/config-data/puppet-generated/octavia/etc/httpd/conf.d/10-octavia_wsgi.conf

Comment 1 Matt Flusche 2020-04-29 15:51:08 UTC
Work-around:

  ControllerExtraConfig:
    octavia::wsgi::apache::servername: "%{hiera('fqdn_internal_api')}"

Comment 8 Omer Schwartz 2020-10-13 14:15:35 UTC
After verification process that involved these steps, I:

Deployed OSP13 with Octavia.

Verified that the hiera parameter in puppet/services/octavia-api.yaml matches the parameter in the puppet module:

[stack@undercloud-0 ~]$ grep "server.*name" /usr/share/openstack-tripleo-heat-templates/puppet/services/octavia-api.yaml
            octavia::wsgi::apache::servername:
[stack@undercloud-0 ~]$ grep -A3 "server.*name" /etc/puppet/modules/octavia/manifests/wsgi/apache.pp
# [*servername*]
#   (Optional) The servername for the virtualhost.
#   Defaults to $::fqdn
#
# [*port*]
--
  $servername                  = $::fqdn,
  $port                        = 9876,
  $bind_host                   = undef,
  $path                        = '/',
--
    servername                  => $servername,
    ssl                         => $ssl,
    ssl_ca                      => $ssl_ca,
    ssl_cert                    => $ssl_cert,
[stack@undercloud-0 ~]$




And also:

[root@controller-0 ~]# hiera -c /etc/puppet/hiera.yaml octavia::wsgi::apache::servername
controller-0.internalapi.redhat.local

[root@controller-0 ~]# grep -i servername /var/lib/config-data/puppet-generated/octavia/etc/httpd/conf.d/10-octavia_wsgi.conf
  ServerName controller-0.internalapi.redhat.local



Puddle:

[stack@undercloud-0 ~]$ cat /var/lib/rhos-release/latest-installed
13  -p 2020-10-06.2



All the commands' results contain 'servername' and none of them contain 'server_name'. The config parameters match.

Looks good to me.

Comment 14 errata-xmlrpc 2020-10-28 18:23:44 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat OpenStack Platform 13.0 director bug fix advisory), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4388