Bug 1829479 - octavia::wsgi::apache::server_name should be octavia::wsgi::apache::servername in puppet/services/octavia-api.yaml
Summary: octavia::wsgi::apache::server_name should be octavia::wsgi::apache::servernam...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: openstack-tripleo-heat-templates
Version: 13.0 (Queens)
Hardware: x86_64
OS: Linux
high
high
Target Milestone: zstream
: 13.0 (Queens)
Assignee: Brent Eagles
QA Contact: Omer Schwartz
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-04-29 15:47 UTC by Matt Flusche
Modified: 2023-10-06 19:48 UTC (History)
6 users (show)

Fixed In Version: openstack-tripleo-heat-templates-8.4.1-58.1.el7ost.noarch.rpm
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-10-28 18:23:44 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Launchpad 1877130 0 None None None 2020-05-06 14:38:00 UTC
OpenStack gerrit 741223 0 None MERGED Fix typo in setting octavia wsgi server name 2021-01-18 22:01:49 UTC
Red Hat Product Errata RHBA-2020:4388 0 None None None 2020-10-28 18:24:00 UTC

Description Matt Flusche 2020-04-29 15:47:38 UTC
Description of problem:

hiera parameter octavia::wsgi::apache::server_name should be octavia::wsgi::apache::servername in puppet/services/octavia-api.yaml to match the parameter in the puppet module.  Currently, always set to $::fqdn


 grep "server.*name" /usr/share/openstack-tripleo-heat-templates/puppet/services/octavia-api.yaml
            octavia::wsgi::apache::server_name:


$ grep -A3 "server.*name" /etc/puppet/modules/octavia/manifests/wsgi/apache.pp                                                   
# [*servername*]
#   (Optional) The servername for the virtualhost.
#   Defaults to $::fqdn
#
# [*port*]
--
  $servername                  = $::fqdn,
  $port                        = 9876,
  $bind_host                   = undef,
  $path                        = '/',
--
    servername                  => $servername,
    ssl                         => $ssl,
    ssl_ca                      => $ssl_ca,
    ssl_cert                    => $ssl_cert,


Version-Release number of selected component (if applicable):

OSP 13

openstack-tripleo-heat-templates-8.4.1-51.el7ost.noarch (current)
puppet-octavia-12.4.0-15.el7ost.noarch (current)


How reproducible:
100%


Steps to Reproduce:
1.  Deploy with octavia & note the hiera config does not match the config for octavia httpd config on the controllers 

sudo hiera -c /etc/puppet/hiera.yaml octavia::wsgi::apache::server_name
sudo grep ServerName /var/lib/config-data/puppet-generated/octavia/etc/httpd/conf.d/10-octavia_wsgi.conf

Comment 1 Matt Flusche 2020-04-29 15:51:08 UTC
Work-around:

  ControllerExtraConfig:
    octavia::wsgi::apache::servername: "%{hiera('fqdn_internal_api')}"

Comment 8 Omer Schwartz 2020-10-13 14:15:35 UTC
After verification process that involved these steps, I:

Deployed OSP13 with Octavia.

Verified that the hiera parameter in puppet/services/octavia-api.yaml matches the parameter in the puppet module:

[stack@undercloud-0 ~]$ grep "server.*name" /usr/share/openstack-tripleo-heat-templates/puppet/services/octavia-api.yaml
            octavia::wsgi::apache::servername:
[stack@undercloud-0 ~]$ grep -A3 "server.*name" /etc/puppet/modules/octavia/manifests/wsgi/apache.pp
# [*servername*]
#   (Optional) The servername for the virtualhost.
#   Defaults to $::fqdn
#
# [*port*]
--
  $servername                  = $::fqdn,
  $port                        = 9876,
  $bind_host                   = undef,
  $path                        = '/',
--
    servername                  => $servername,
    ssl                         => $ssl,
    ssl_ca                      => $ssl_ca,
    ssl_cert                    => $ssl_cert,
[stack@undercloud-0 ~]$




And also:

[root@controller-0 ~]# hiera -c /etc/puppet/hiera.yaml octavia::wsgi::apache::servername
controller-0.internalapi.redhat.local

[root@controller-0 ~]# grep -i servername /var/lib/config-data/puppet-generated/octavia/etc/httpd/conf.d/10-octavia_wsgi.conf
  ServerName controller-0.internalapi.redhat.local



Puddle:

[stack@undercloud-0 ~]$ cat /var/lib/rhos-release/latest-installed
13  -p 2020-10-06.2



All the commands' results contain 'servername' and none of them contain 'server_name'. The config parameters match.

Looks good to me.

Comment 14 errata-xmlrpc 2020-10-28 18:23:44 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat OpenStack Platform 13.0 director bug fix advisory), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4388


Note You need to log in before you can comment on or make changes to this bug.