Bug 1829543

Summary:	Stop using deprecated "migrate_set_downtime" QMP command
Product:	Red Hat Enterprise Linux Advanced Virtualization	Reporter:	Peter Krempa <pkrempa>
Component:	libvirt	Assignee:	Jiri Denemark <jdenemar>
Status:	CLOSED ERRATA	QA Contact:	Fangge Jin <fjin>
Severity:	medium	Docs Contact:
Priority:	high
Version:	8.2	CC:	chhu, hhan, jdenemar, jsuchane, lizhu, lmen, virt-maint, xuzhang
Target Milestone:	rc	Keywords:	Triaged
Target Release:	8.3
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	libvirt-6.5.0-1.el8	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1829704 (view as bug list)		Environment:
Last Closed:	2020-11-17 17:48:27 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1829704

Description Peter Krempa 2020-04-29 18:22:14 UTC

Description of problem:
"migrate_set_downtime" is deprecated since qemu-2.8 and should be replaced by 'migrate-set-parameters". Libvirt still uses it in qemuDomainMigrateSetMaxDowntime without alternative.

When fixing this, please also adjust the test case to mark the command as okay to be removed.

Comment 1 Jiri Denemark 2020-06-10 18:26:42 UTC

Patches sent upstream for review: https://www.redhat.com/archives/libvir-list/2020-June/msg00444.html

Comment 2 Jiri Denemark 2020-06-17 08:28:44 UTC

Fixed upstream by

commit 65de5f6fe4c2ba4f7baabb43a66d64877a9c95fd
Refs: v6.4.0-124-g65de5f6fe4
Author:     Jiri Denemark <jdenemar>
AuthorDate: Wed Jun 10 16:13:15 2020 +0200
Commit:     Jiri Denemark <jdenemar>
CommitDate: Wed Jun 17 10:25:33 2020 +0200

    qemu: Avoid deprecated migrate_set_downtime QMP command

    The same functionality can be achieved using migrate-set-parameters QMP
    command with downtime-limit parameter.

    https://bugzilla.redhat.com/show_bug.cgi?id=1829543

    Signed-off-by: Jiri Denemark <jdenemar>
    Reviewed-by: Peter Krempa <pkrempa>

Comment 5 Fangge Jin 2020-07-31 09:35:56 UTC

Verify with:
libvirt-client-6.5.0-1.module+el8.3.0+7323+d54bb644.x86_64
qemu-kvm-5.0.0-2.module+el8.3.0+7379+0505d6ca.x86_64


Result:
migrate-set-parameters is used when set maxdowntime

Steps:
# virsh migrate-setmaxdowntime rhel7-min 200

2020-07-31 09:34:21.770+0000: 70043: info : qemuMonitorSend:946 : QEMU_MONITOR_SEND_MSG: mon=0x7f95b8047020 msg={"execute":"migrate-set-parameters","arguments":{"downtime-limit":200},"id":"libvirt-382"}

Comment 6 Fangge Jin 2020-07-31 09:36:30 UTC

Still need to verify with qemu-kvm that doesn't support set maxdowntime via migrate-set-parameters

Comment 7 Fangge Jin 2020-08-27 09:41:49 UTC

(In reply to Fangge Jin from comment #6)
> Still need to verify with qemu-kvm that doesn't support set maxdowntime via
> migrate-set-parameters

To test this scenario, I will have to test upgrade from RHEL7.3 to RHELAV-8.3, which is not supported.
So this bug can be marked as verified.

Comment 10 errata-xmlrpc 2020-11-17 17:48:27 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (virt:8.3 bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:5137