Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1829704

Summary:	Stop using deprecated "migrate_set_downtime" QMP command
Product:	Red Hat Enterprise Linux Advanced Virtualization	Reporter:	Li Xiaohui <xiaohli>
Component:	qemu-kvm	Assignee:	Jiri Herrmann <jherrman>
qemu-kvm sub component:	Live Migration	QA Contact:	Li Xiaohui <xiaohli>
Status:	CLOSED UPSTREAM	Docs Contact:
Severity:	unspecified
Priority:	unspecified	CC:	chayang, ehabkost, fjin, jinzhao, juzhang, pkrempa, qzhang, virt-maint, xianwang
Version:	8.2	Keywords:	TestOnly
Target Milestone:	rc
Target Release:	8.3
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1829543	Environment:
Last Closed:	2020-07-07 00:34:49 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1829543
Bug Blocks:

Description Li Xiaohui 2020-04-30 07:11:32 UTC

+++ This bug was initially created as a clone of Bug #1829543 +++

Description of problem:
"migrate_set_downtime" is deprecated since qemu-2.8 and should be replaced by 'migrate-set-parameters". Libvirt still uses it in qemuDomainMigrateSetMaxDowntime without alternative.

When fixing this, please also adjust the test case to mark the command as okay to be removed.

Comment 3 Li Xiaohui 2020-06-15 08:04:30 UTC

Thanks for the remind. 
I will update migration test plan after libvirt remove them and use the replace by default on 8.3.0-av.

Comment 5 Peter Krempa 2020-06-15 18:00:51 UTC

This bug was originally cloned from a libvirt bug, which is assigned and being worked on. Reassigning it to libvirt doesn't make sense.

Comment 6 Eduardo Habkost 2020-06-15 18:08:27 UTC

(In reply to Peter Krempa from comment #5)
> This bug was originally cloned from a libvirt bug, which is assigned and
> being worked on. Reassigning it to libvirt doesn't make sense.

I don't understand why this bug exists, then.  Why was this BZ created?

Comment 7 Li Xiaohui 2020-06-16 02:07:21 UTC

(In reply to Eduardo Habkost from comment #6)
> (In reply to Peter Krempa from comment #5)
> > This bug was originally cloned from a libvirt bug, which is assigned and
> > being worked on. Reassigning it to libvirt doesn't make sense.
> 
> I don't understand why this bug exists, then.  Why was this BZ created?

This bz just be tracked on qemu side. 
I think we need update besides libvirt side, also need from qemu, so clone bz from libvirt.

Comment 8 Eduardo Habkost 2020-06-17 22:40:18 UTC

The summary and description of the BZ doesn't mention anything that needs to be done on the QEMU side.  QEMU itself is not a user of QMP commands.

If there's any task to be done on the QEMU side, please explain what needs to be done so we can change the BZ summary and description accordingly.  If there's no task to be done, I will close this BZ.

Comment 9 Li Xiaohui 2020-06-18 08:38:13 UTC

(In reply to Eduardo Habkost from comment #8)
> The summary and description of the BZ doesn't mention anything that needs to
> be done on the QEMU side.  QEMU itself is not a user of QMP commands.
Well noted, thanks

> If there's any task to be done on the QEMU side, please explain what needs
> to be done so we can change the BZ summary and description accordingly.  If
> there's no task to be done, I will close this BZ.
Yes, we want to document in qemu that these commands are deprecated on rhel8.3-av when related libvirt bz(Bug #1829543) fixed

Comment 11 Eduardo Habkost 2020-07-06 18:44:29 UTC

(In reply to Li Xiaohui from comment #9)
> (In reply to Eduardo Habkost from comment #8)
> > The summary and description of the BZ doesn't mention anything that needs to
> > be done on the QEMU side.  QEMU itself is not a user of QMP commands.
> Well noted, thanks
> 
> > If there's any task to be done on the QEMU side, please explain what needs
> > to be done so we can change the BZ summary and description accordingly.  If
> > there's no task to be done, I will close this BZ.
> Yes, we want to document in qemu that these commands are deprecated on
> rhel8.3-av when related libvirt bz(Bug #1829543) fixed

The QEMU documentation already indicates that migrate_set_downtime is deprecated:
https://www.qemu.org/docs/master/interop/qemu-qmp-ref.html#index-migrate_005fset_005fdowntime

There's no customer documentation for QMP commands, so I still don't understand what needs to be done for this BZ.  Please clarify which documentation needs to be updated.

Comment 12 Li Xiaohui 2020-07-07 00:31:17 UTC

(In reply to Eduardo Habkost from comment #11)
> (In reply to Li Xiaohui from comment #9)
> > (In reply to Eduardo Habkost from comment #8)
> > > The summary and description of the BZ doesn't mention anything that needs to
> > > be done on the QEMU side.  QEMU itself is not a user of QMP commands.
> > Well noted, thanks
> > 
> > > If there's any task to be done on the QEMU side, please explain what needs
> > > to be done so we can change the BZ summary and description accordingly.  If
> > > there's no task to be done, I will close this BZ.
> > Yes, we want to document in qemu that these commands are deprecated on
> > rhel8.3-av when related libvirt bz(Bug #1829543) fixed
> 
> The QEMU documentation already indicates that migrate_set_downtime is
> deprecated:
> https://www.qemu.org/docs/master/interop/qemu-qmp-ref.html#index-
> migrate_005fset_005fdowntime
> 
> There's no customer documentation for QMP commands, so I still don't
> understand what needs to be done for this BZ.  Please clarify which
> documentation needs to be updated.

Thanks, having seen the QEMU documentation.
I'm ok to close this bz.